cpw.rekkanoryo.icqxstatus: c7a31c2a: disapproval of revision '03cc34e11e1b18b...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Tue Feb 9 17:40:56 EST 2010


-----------------------------------------------------------------
Revision: c7a31c2a657883fbaf9577a5d0fd7c2b7731e207
Ancestor: 03cc34e11e1b18bf814df23432b056322bebca01
Author: darkrain42 at pidgin.im
Date: 2010-02-09T22:38:47
Branch: im.pidgin.cpw.rekkanoryo.icqxstatus
URL: http://d.pidgin.im/viewmtn/revision/info/c7a31c2a657883fbaf9577a5d0fd7c2b7731e207

Modified files:
        libpurple/protocols/oscar/oscar.h

ChangeLog: 

disapproval of revision '03cc34e11e1b18bf814df23432b056322bebca01'

Per conversation in devel at cpi, this still needs to be fixed (it sounds like either a bit-packed structure or a bunch of #defines are the leading "solutions")

-------------- next part --------------
============================================================
--- libpurple/protocols/oscar/oscar.h	d43c1e5acb65f8e7c0e575f6d8f01dfb1627108c
+++ libpurple/protocols/oscar/oscar.h	3d464afe8a58f6a47e8159afb553d3ea36d6f93c
@@ -378,6 +378,8 @@ typedef enum
 	OSCAR_CAPABILITY_NEWCAPS              = 0x20000000,
 	OSCAR_CAPABILITY_XTRAZ                = 0x40000000,
 	OSCAR_CAPABILITY_GENERICUNKNOWN       = 0x80000000,
+#warning Fix OSCAR_CAPABILITY_LAST situation
+	// TODO: We're out of bits.  Rework things that depend on this or remove some capability. (Or, ensure this is a 64-bit type.)
 	OSCAR_CAPABILITY_LAST                 = 0x100000000	
 } OscarCapability;
 


More information about the Commits mailing list