pidgin: ab4716ed: Fix CVE-2010-0420, a possible remote cra...

[markdoliner at pidgin.im]

-----------------------------------------------------------------
Revision: ab4716ed6857f669ceb0296e5480729aafba2e9f
Ancestor: 784bc8bff5affb83cee8a5a9353cb0a8220a72ce
Author: markdoliner at pidgin.im
Date: 2010-02-16T08:58:45
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/ab4716ed6857f669ceb0296e5480729aafba2e9f

Modified files:
        ChangeLog finch/libgnt/gnttree.c

ChangeLog: 

Fix CVE-2010-0420, a possible remote crash when handling chat room
buddy names.

-------------- next part --------------
============================================================
--- ChangeLog	9136e0d000cf003ec7199cbf801b6aa49141baa8
+++ ChangeLog	281226fa9dd8739311f42241fe18d563b8fb57f8
@@ -102,6 +102,8 @@ version 2.6.6 (02/18/2010):
 	  descriptions not to be displayed in the theme selector.
 
 	Finch:
+	* Fix CVE-2010-0420, a possible remote crash when handling chat room
+	  buddy names.
 	* Rebindable 'move-first' and 'move-last' actions for tree widgets. So
 	  it is possible to jump to the first or last entry in the buddy list
 	  (and other such lists) by pressing home or end key (defaults)
============================================================
--- finch/libgnt/gnttree.c	c0457339498931f7f285d1d524dae9eb30c07806
+++ finch/libgnt/gnttree.c	9a67dd86759ceb0b59bb05db653b8cf76911d9e2
@@ -1346,6 +1346,10 @@ GntTreeRow *gnt_tree_add_row_after(GntTr
 {
 	GntTreeRow *pr = NULL;
 
+	if (g_hash_table_lookup(tree->hash, key)) {
+		gnt_tree_remove(tree, key);
+	}
+
 	row->tree = tree;
 	row->key = key;
 	row->data = NULL;