www: 9721a576: Support a comma delimited list of revisi...

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Feb 18 04:00:54 EST 2010


-----------------------------------------------------------------
Revision: 9721a57646b54728eabe94b0a8742280fa6f690b
Ancestor: f3e8225df92ae462ca4c7b2ed1ce732313641b03
Author: markdoliner at pidgin.im
Date: 2010-02-18T08:58:20
Branch: im.pidgin.www
URL: http://d.pidgin.im/viewmtn/revision/info/9721a57646b54728eabe94b0a8742280fa6f690b

Modified files:
        htdocs/news/security/index.php

ChangeLog: 

Support a comma delimited list of revisions.  Used for
http://pidgin.im/news/security/?id=44

-------------- next part --------------
============================================================
--- htdocs/news/security/index.php	b4e6b1b9a6654a099b9594bacdc4920e9908d721
+++ htdocs/news/security/index.php	5a2e0d491a13a6b8cb2e3ef0ce6d915f02de8ba6
@@ -608,11 +608,16 @@ if ($stop > 0) {
   <tr><th>Description</th><td><?=$vun['description']?></td></tr>
 
   <?
-	// TODO: We should treat fixrevisions like a comma delimited list of
-	//       revisions and linkify each one individually.
-    if (array_key_exists('fixrevisions', $vun) && !empty($vun['fixrevisions'])) {
+	if (array_key_exists('fixrevisions', $vun) && !empty($vun['fixrevisions'])) {
+		// fixrevisions is a comma delimited list of revisions.  Linkify each one individually.
+		$fixrevisions = '';
+		foreach (explode(',', $vun['fixrevisions']) as $revision) {
+			if (!empty($fixrevisions))
+				$fixrevisions .= "<br/>";
+			$fixrevisions .= "<a href=\"http://developer.pidgin.im/viewmtn/revision/info/$revision\">$revision</a>";
+		}
   ?>
-  <tr><th>Fixed in Revision</th><td><a href="http://developer.pidgin.im/viewmtn/revision/info/<?=$vun['fixrevisions']?>"><?=$vun['fixrevisions']?></a></td></tr>
+  <tr><th>Fixed in Revision</th><td><?=$fixrevisions?></td></tr>
   <?
     }
   ?>


More information about the Commits mailing list