pidgin: e6cd9f8f: I think this is only the place this coul...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Thu Jan 14 14:55:34 EST 2010


-----------------------------------------------------------------
Revision: e6cd9f8f748648ec43656d1d7e7042fd7f8d281d
Ancestor: f57115801692578a12eb345cec17051de96de291
Author: darkrain42 at pidgin.im
Date: 2010-01-14T18:37:32
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/e6cd9f8f748648ec43656d1d7e7042fd7f8d281d

Modified files:
        pidgin/gtkutils.c

ChangeLog: 

I think this is only the place this could leak...

==14064== 36 bytes in 2 blocks are definitely lost in loss record 13,092 of 20,211
==14064==    at 0x4024C1C: malloc (vg_replace_malloc.c:195)
==14064==    by 0x4A73B0F: __vasprintf_chk (vasprintf_chk.c:82)
==14064==    by 0x485197E: g_vasprintf (in /lib/libglib-2.0.so.0.2200.3)
==14064==    by 0x483D485: g_strdup_vprintf (in /lib/libglib-2.0.so.0.2200.3)
==14064==    by 0x483D4A7: g_strdup_printf (in /lib/libglib-2.0.so.0.2200.3)
==14064==    by 0x492FC6D: purple_mkstemp (util.c:2916)
==14064==    by 0x80FEDD5: pidgin_convert_buddy_icon (gtkutils.c:2690)

-------------- next part --------------
============================================================
--- pidgin/gtkutils.c	d0ac2b238d7b99044bd153d560d0d0db5b90589e
+++ pidgin/gtkutils.c	4f0df80ed18d094ec1f75c7e79d2e9cc14059f52
@@ -2723,6 +2723,7 @@ pidgin_convert_buddy_icon(PurplePlugin *
 		g_object_unref(G_OBJECT(pixbuf));
 		if (!success) {
 			purple_debug_error("buddyicon", "Could not convert icon to usable format.\n");
+			g_free(filename);
 			return NULL;
 		}
 


More information about the Commits mailing list