pidgin: 18cd6564: We shouldn't free user->extinfo here bec...

qulogic at pidgin.im qulogic at pidgin.im
Wed Jun 2 19:55:35 EDT 2010


-----------------------------------------------------------------
Revision: 18cd6564fcc8549ee15525d25d4f913970d3732a
Ancestor: 5659c7bbef24cb9a8c8a573ce4371598b5316649
Author: qulogic at pidgin.im
Date: 2010-06-02T23:29:21
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/18cd6564fcc8549ee15525d25d4f913970d3732a

Modified files:
        libpurple/protocols/msn/notification.c

ChangeLog: 

We shouldn't free user->extinfo here because it can also contain phone
numbers. Mark says freeing this struct at this point is not so much of a
priority in the grand scheme of saving memory.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/notification.c	fdbe9376497f0701dc1405014f64977240d98a90
+++ libpurple/protocols/msn/notification.c	71c65de3d7d7119f105f39002f5d98c8856c748e
@@ -1610,11 +1610,6 @@ ubx_cmd_post(MsnCmdProc *cmdproc, MsnCom
 		msn_user_set_statusline(user, NULL);
 	}
 
-	if (user->extinfo && user->extinfo->media_type == CURRENT_MEDIA_UNKNOWN) {
-		g_free(user->extinfo);
-		user->extinfo = NULL;
-	}
-
 	msn_user_update(user);
 }
 


More information about the Commits mailing list