pidgin: ceb005fd: jabber: Document the other cyrus hack (i...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: ceb005fdb6c0df6220be2407cb7e30d74c470667
Ancestor: 63223dd28d39ec1b2e6b4f834003f60f33583385
Author: darkrain42 at pidgin.im
Date: 2010-06-12T23:01:44
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/ceb005fdb6c0df6220be2407cb7e30d74c470667

Modified files:
        libpurple/protocols/jabber/auth_cyrus.c

ChangeLog: 

jabber: Document the other cyrus hack (ignoring EXTERNAL)

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/auth_cyrus.c	3f23cf2f2b7f4616ebedaf633dcdda0dadc91efb
+++ libpurple/protocols/jabber/auth_cyrus.c	4b15693ad4c1683516c1a26132737e98e4e4f471
@@ -408,6 +408,12 @@ jabber_cyrus_start(JabberStream *js, xml
 	{
 		char *mech_name = xmlnode_get_data(mechnode);
 
+		/* Ignore blank mechanisms and EXTERNAL.  External isn't
+		 * supported, and Cyrus SASL's mechanism returns
+		 * SASL_NOMECH when the caller (us) doesn't configure it.
+		 * Except SASL_NOMECH is supposed to mean "no concordant
+		 * mechanisms"...  Easiest just to blacklist it (for now).
+		 */
 		if (!mech_name || !*mech_name ||
 				g_str_equal(mech_name, "EXTERNAL")) {
 			g_free(mech_name);