pidgin: 17361f09: Fix a typo and solve a crash. g_free() ...

rekkanoryo at pidgin.im rekkanoryo at pidgin.im
Thu Jun 17 18:25:47 EDT 2010


-----------------------------------------------------------------
Revision: 17361f09097a5f1f0b18ee376798623ad992ef35
Ancestor: 957a4bbd52c402829dbe3dbe7a88d69e70d00a97
Author: rekkanoryo at pidgin.im
Date: 2010-06-17T22:20:25
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/17361f09097a5f1f0b18ee376798623ad992ef35

Modified files:
        libpurple/protocols/yahoo/libymsg.c

ChangeLog: 

Fix a typo and solve a crash.  g_free() is not safe on uninitialized pointers.

-------------- next part --------------
============================================================
--- libpurple/protocols/yahoo/libymsg.c	ff966131fb334d1a9f45da8f4ab0767ef6db302a
+++ libpurple/protocols/yahoo/libymsg.c	e02aeb1ac11c66512e8892a40da7841e6d14762c
@@ -402,10 +402,10 @@ static void yahoo_do_group_check(PurpleA
 	PurpleGroup *g;
 	GSList *list, *i;
 	gboolean onlist = FALSE;
-	char *oname;
+	char *oname = NULL;
 
 	if (g_hash_table_lookup_extended(ht, purple_normalize(account, name), (gpointer *)&oname, (gpointer *)&list))
-		g_hash_table_steal(ht, oname);
+		g_hash_table_steal(ht, name);
 	else
 		list = purple_find_buddies(account, name);
 


More information about the Commits mailing list