pidgin: 3762c933: Add a cast to silence this warning.

markdoliner at pidgin.im markdoliner at pidgin.im
Thu Mar 4 16:31:14 EST 2010


-----------------------------------------------------------------
Revision: 3762c9332c14ac3b681bae2c99c49773c2e46e8a
Ancestor: b84cb254e83a2dd3b31443d05163b32875e98fdf
Author: markdoliner at pidgin.im
Date: 2010-03-04T21:25:50
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/3762c9332c14ac3b681bae2c99c49773c2e46e8a

Modified files:
        libpurple/plugins/perl/perl-handlers.c

ChangeLog: 

Add a cast to silence this warning.
perl-handlers.c: In function 'perl_signal_cb':
perl-handlers.c:306: warning: passing argument 2 of 'purple_perl_sv_from_vargs' from incompatible pointer type
perl-common.h:69: note: expected 'struct __va_list_tag (*)[1]' but argument is of type 'struct __va_list_tag *'

This may not be the most elegant solution, but va_args aren't really elegant,
and this solution is at least easy.

Thanks very much to the expert bug reporting and research done by
dharding!

Fixes #11431 (that ticket has a lot of information about this change)

-------------- next part --------------
============================================================
--- libpurple/plugins/perl/perl-handlers.c	2011d190d936b5e90a132e189b1b80db06cc2c37
+++ libpurple/plugins/perl/perl-handlers.c	79fadbaf8709ffd84040f0c17c93f3e75f884df5
@@ -299,7 +299,7 @@ perl_signal_cb(va_list args, void *data)
 	for (i = 0; i < value_count; i++) {
 		sv_args[i] = purple_perl_sv_from_vargs(values[i],
 #ifdef VA_COPY_AS_ARRAY
-		                                       args,
+		                                       (va_list*)args,
 #else
 		                                       (va_list*)&args,
 #endif


More information about the Commits mailing list