pidgin: ca3daabf: ft: uhm, no. s can't be 0 here, it's ch...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Fri Mar 5 17:25:53 EST 2010


-----------------------------------------------------------------
Revision: ca3daabfbe02e853b3cc37b80ebe1746df97932a
Ancestor: 81bf09b82728c27c0e2988d78b62013cb9a06f3b
Author: darkrain42 at pidgin.im
Date: 2010-03-05T22:15:16
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/ca3daabfbe02e853b3cc37b80ebe1746df97932a

Modified files:
        libpurple/ft.c

ChangeLog: 

ft: uhm, no.  s can't be 0 here, it's checked above (with a return).

-------------- next part --------------
============================================================
--- libpurple/ft.c	3431026e58910a3b731ff08b977596630f57aad8
+++ libpurple/ft.c	1f62ea837f1ebc131e374e58724854e0e643883c
@@ -1115,13 +1115,7 @@ do_transfer(PurpleXfer *xfer)
 				/* Need to indicate the prpl is still ready... */
 				priv->ready |= PURPLE_XFER_READY_PRPL;
 
-				/*
-				 * if we requested 0 bytes it's only normal that end up here 
-				 * we shouldn't return as we still have something to 
-				 * write in priv->buffer
-				 */
-				if (s != 0)
-					g_return_if_reached();
+				g_return_if_reached();
 			} else if (tmp < 0) {
 				purple_debug_error("filetransfer", "Unable to read whole buffer.\n");
 				purple_xfer_cancel_local(xfer);


More information about the Commits mailing list