pidgin: 78026d85: jabber: Connected again; checked section...

[darkrain42 at pidgin.im]

-----------------------------------------------------------------
Revision: 78026d85fc783da9d0cb93283729d22e5248c42b
Ancestor: 18414cb741f06614ba4161a194c333489c93a758
Author: darkrain42 at pidgin.im
Date: 2010-03-10T01:25:24
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/78026d85fc783da9d0cb93283729d22e5248c42b

Modified files:
        libpurple/protocols/jabber/parser.c

ChangeLog: 

jabber: Connected again; checked section 5.4.5 of the bis.

"The minor version number MUST be ignored by an entity with a smaller
minor version number"

I really need to keep a copy of all the XMPP specs on my laptop.

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/parser.c	83aa7420a105a76ba89f68aa4a8f065be43fd9a8
+++ libpurple/protocols/jabber/parser.c	f437ba12b5fb1072cb91af9c79f26b02933d0856
@@ -56,10 +56,8 @@ jabber_parser_element_start_libxml(void 
 				js->protocol_version.major = atoi(attrib);
 				js->protocol_version.minor = dot ? atoi(dot + 1) : 0;
 
-				/* TODO: Check this against the spec; I'm not sure if the check
-				 * against minor is accurate.
-				 */
-				if (js->protocol_version.major > 1 || (js->protocol_version == 1 && js->protocol_version.minor > 0))
+				if (js->protocol_version.major > 1)
+					/* TODO: Send <unsupported-version/> error */
 					purple_connection_error_reason(js->gc,
 							PURPLE_CONNECTION_ERROR_AUTHENTICATION_IMPOSSIBLE,
 							_("XMPP Version Mismatch"));