adium.1-4: 1f5f812e: This hack to manually handle X-GOOGLE-TO...

evands at pidgin.im evands at pidgin.im
Mon May 3 22:15:32 EDT 2010


-----------------------------------------------------------------
Revision: 1f5f812e500972cfb805d2cf0b3bc423cf2b7f3f
Ancestor: 8b6590428d8180cc466c8916f81aec2c8961fbd1
Author: evands at pidgin.im
Date: 2010-05-04T01:57:07
Branch: im.pidgin.adium.1-4
URL: http://d.pidgin.im/viewmtn/revision/info/1f5f812e500972cfb805d2cf0b3bc423cf2b7f3f

Modified files:
        libpurple/protocols/jabber/auth_cyrus.c

ChangeLog: 

This hack to manually handle X-GOOGLE-TOKEN an X-FACEBOOK-PLATFORM shouldn't be needed now; avoiding them was masking the problem, since we should be prepared for a server to offer any number of arbitrary mechs which we may or may not be able to handle.

-------------- next part --------------
============================================================
--- libpurple/protocols/jabber/auth_cyrus.c	7b18f7eac5d6e59383b4811501fcc55dcfe738e8
+++ libpurple/protocols/jabber/auth_cyrus.c	7cfaf24c96ed114247da8ca081ca1d4a77644bd6
@@ -408,17 +408,6 @@ jabber_cyrus_start(JabberStream *js, xml
 			continue;
 		}
 
-		/* Don't include Google Talk's X-GOOGLE-TOKEN mechanism
-		 * or Facebook Chat's X-FACEBOOK-PLATFORM mechansim,
-		 * as we will not support them and including them gives a false fall-back
-		 * to other mechs offerred, leading to incorrect error handling.
-		 */
-		if (g_str_equal(mech_name, "X-GOOGLE-TOKEN")
-				|| g_str_equal(mech_name, "X-FACEBOOK-PLATFORM") ) {
-			g_free(mech_name);
-			continue;
-		}
-
 		g_string_append(js->sasl_mechs, mech_name);
 		g_string_append_c(js->sasl_mechs, ' ');
 		g_free(mech_name);


More information about the Commits mailing list