pidgin: 9a6a7aa6: I don't know why this function returns a...

[qulogic at pidgin.im]

-----------------------------------------------------------------
Revision: 9a6a7aa6835c4e6a55006750e5f92f7bc050e063
Ancestor: bce9d68c131147c0724ad3525a1a93e5d2a862ff
Author: qulogic at pidgin.im
Date: 2010-05-21T04:07:02
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/9a6a7aa6835c4e6a55006750e5f92f7bc050e063

Modified files:
        libpurple/protocols/msn/slp.c

ChangeLog: 

I don't know why this function returns a boolean that's never used.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slp.c	c4690b789b6be8a35884cfb36d92f6dc8339a027
+++ libpurple/protocols/msn/slp.c	09359dfed30d12a6c9be41dd7d60119c9f984ed3
@@ -312,7 +312,7 @@ parse_dc_nonce(const char *content, MsnD
 	return nonce;
 }
 
-static gboolean
+static void
 msn_slp_process_transresp(MsnSlpCall *slpcall, const char *content)
 {
 	/* A direct connection negotiation response */
@@ -321,16 +321,15 @@ msn_slp_process_transresp(MsnSlpCall *sl
 	char *listening;
 	MsnDirectConn *dc = slpcall->slplink->dc;
 	MsnDirectConnNonceType ntype;
-	gboolean result = FALSE;
 
 	purple_debug_info("msn", "process_transresp\n");
 
 	/* Direct connections are disabled. */
 	if (!purple_account_get_bool(slpcall->slplink->session->account, "direct_connect", TRUE))
-		return FALSE;
+		return;
 
-	g_return_val_if_fail(dc != NULL, FALSE);
-	g_return_val_if_fail(dc->state == DC_STATE_CLOSED, FALSE);
+	g_return_if_fail(dc != NULL);
+	g_return_if_fail(dc->state == DC_STATE_CLOSED);
 
 	bridge = get_token(content, "Bridge: ", "\r\n");
 	nonce = parse_dc_nonce(content, &ntype);
@@ -447,8 +446,6 @@ msn_slp_process_transresp(MsnSlpCall *sl
 			g_free(ip);
 		}
 
-		result = TRUE;
-
 	} else {
 		/*
 		 * Invalid direct connect invitation or
@@ -460,7 +457,7 @@ msn_slp_process_transresp(MsnSlpCall *sl
 	g_free(nonce);
 	g_free(bridge);
 
-	return result;
+	return;
 }
 
 static void