pidgin: 637cbec3: Don't free captcha_req just before deref...

nosnilmot at pidgin.im nosnilmot at pidgin.im
Sun May 23 12:55:50 EDT 2010


-----------------------------------------------------------------
Revision: 637cbec3044756a8ef4273f687d84b18f10b05c4
Ancestor: 33241f3632f601e8ace61225c00da28f8cab9e8e
Author: nosnilmot at pidgin.im
Date: 2010-05-23T16:53:24
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/637cbec3044756a8ef4273f687d84b18f10b05c4

Modified files:
        libpurple/protocols/qq/qq_base.c

ChangeLog: 

Don't free captcha_req just before dereferencing it.
Probably fixes https://bugzilla.redhat.com/show_bug.cgi?id=583507

-------------- next part --------------
============================================================
--- libpurple/protocols/qq/qq_base.c	e5dd8ef10e99043103acced8a42c982a23fe6f86
+++ libpurple/protocols/qq/qq_base.c	7a4971b102422fbf720cefd1bddf90f35eb6c5d0
@@ -811,11 +811,11 @@ static void captcha_input_cancel_cb(qq_c
 static void captcha_input_cancel_cb(qq_captcha_request *captcha_req,
 		PurpleRequestFields *fields)
 {
-	captcha_request_destory(captcha_req);
-
 	purple_connection_error_reason(captcha_req->gc,
 			PURPLE_CONNECTION_ERROR_AUTHENTICATION_FAILED,
 			_("Failed captcha verification"));
+
+	captcha_request_destory(captcha_req);
 }
 
 static void captcha_input_ok_cb(qq_captcha_request *captcha_req,


More information about the Commits mailing list