pidgin: 7786ed6f: Correctly reset and free user->extinfo w...

qulogic at pidgin.im qulogic at pidgin.im
Mon May 31 02:55:50 EDT 2010


-----------------------------------------------------------------
Revision: 7786ed6f7931081801ff5a3435820ed6f90ba2ca
Ancestor: 464fb4a5f74b2f201eff0ddd41d7fe95e905b51f
Author: qulogic at pidgin.im
Date: 2010-05-31T06:51:16
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/7786ed6f7931081801ff5a3435820ed6f90ba2ca

Modified files:
        libpurple/protocols/msn/notification.c

ChangeLog: 

Correctly reset and free user->extinfo when the buddy is not listening to
anything, or the tune icon will stay around for no reason.

Fixes #12050.

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/notification.c	973bcd54133e6302e1e737e948b7d908d49f9dd3
+++ libpurple/protocols/msn/notification.c	fdbe9376497f0701dc1405014f64977240d98a90
@@ -1595,6 +1595,7 @@ ubx_cmd_post(MsnCmdProc *cmdproc, MsnCom
 		user->extinfo->media_album = NULL;
 		user->extinfo->media_artist = NULL;
 		user->extinfo->media_title = NULL;
+		user->extinfo->media_type = CURRENT_MEDIA_UNKNOWN;
 	}
 
 	if (len != 0) {
@@ -1609,6 +1610,11 @@ ubx_cmd_post(MsnCmdProc *cmdproc, MsnCom
 		msn_user_set_statusline(user, NULL);
 	}
 
+	if (user->extinfo && user->extinfo->media_type == CURRENT_MEDIA_UNKNOWN) {
+		g_free(user->extinfo);
+		user->extinfo = NULL;
+	}
+
 	msn_user_update(user);
 }
 


More information about the Commits mailing list