pidgin: cb7ade72: Remove dead assignments in new MSN code.
qulogic at pidgin.im
qulogic at pidgin.im
Fri Nov 5 23:50:57 EDT 2010
----------------------------------------------------------------------
Revision: cb7ade72337c47ff573ca4b1e231d5e4980ffa93
Parent: d4d69fea75073152418e32247324703f325b532f
Author: qulogic at pidgin.im
Date: 11/04/10 00:41:48
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/cb7ade72337c47ff573ca4b1e231d5e4980ffa93
Changelog:
Remove dead assignments in new MSN code.
Changes against parent d4d69fea75073152418e32247324703f325b532f
patched libpurple/protocols/msn/notification.c
patched libpurple/protocols/msn/slp.c
patched libpurple/protocols/msn/switchboard.c
patched libpurple/protocols/msn/userlist.c
-------------- next part --------------
============================================================
--- libpurple/protocols/msn/switchboard.c f18d56f3ddf75f76758949e2d6469f736d3e3fd0
+++ libpurple/protocols/msn/switchboard.c 8ab17b1d4e238ac3cfea402d5c0c694273afbe59
@@ -678,11 +678,9 @@ iro_cmd(MsnCmdProc *cmdproc, MsnCommand
iro_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
PurpleAccount *account;
- PurpleConnection *gc;
MsnSwitchBoard *swboard;
account = cmdproc->session->account;
- gc = account->gc;
swboard = cmdproc->data;
swboard->total_users = atoi(cmd->params[2]);
@@ -695,7 +693,6 @@ joi_cmd(MsnCmdProc *cmdproc, MsnCommand
{
MsnSession *session;
PurpleAccount *account;
- PurpleConnection *gc;
MsnSwitchBoard *swboard;
const char *passport;
@@ -703,7 +700,6 @@ joi_cmd(MsnCmdProc *cmdproc, MsnCommand
session = cmdproc->session;
account = session->account;
- gc = account->gc;
swboard = cmdproc->data;
msn_switchboard_add_user(swboard, passport);
============================================================
--- libpurple/protocols/msn/notification.c 49eac45cd96eb7b562bc327a81a8d914e156c7cb
+++ libpurple/protocols/msn/notification.c d92c9a3379254840c21d8230b52f0c9ec5547f0e
@@ -95,7 +95,6 @@ connect_cb(MsnServConn *servconn)
MsnCmdProc *cmdproc;
MsnSession *session;
MsnTransaction *trans;
- PurpleAccount *account;
GString *vers;
const char *ver_str;
int i;
@@ -104,7 +103,6 @@ connect_cb(MsnServConn *servconn)
cmdproc = servconn->cmdproc;
session = servconn->session;
- account = session->account;
vers = g_string_new("");
@@ -189,12 +187,8 @@ usr_cmd(MsnCmdProc *cmdproc, MsnCommand
static void
usr_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
- MsnSession *session;
- PurpleAccount *account;
+ MsnSession *session = cmdproc->session;
- session = cmdproc->session;
- account = session->account;
-
if (!g_ascii_strcasecmp(cmd->params[1], "OK"))
{
/* authenticate OK */
@@ -732,11 +726,8 @@ adl_cmd_parse(MsnCmdProc *cmdproc, MsnCo
for (domain_node = xmlnode_get_child(root, "d");
domain_node;
domain_node = xmlnode_get_next_twin(domain_node)) {
- const gchar * domain = NULL;
xmlnode *contact_node = NULL;
- domain = xmlnode_get_attrib(domain_node, "n");
-
for (contact_node = xmlnode_get_child(domain_node, "c");
contact_node;
contact_node = xmlnode_get_next_twin(contact_node)) {
@@ -1021,8 +1012,6 @@ iln_cmd(MsnCmdProc *cmdproc, MsnCommand
iln_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session;
- PurpleAccount *account;
- PurpleConnection *gc;
MsnUser *user;
MsnObject *msnobj = NULL;
unsigned long clientid, extcaps;
@@ -1032,8 +1021,6 @@ iln_cmd(MsnCmdProc *cmdproc, MsnCommand
char *friendly;
session = cmdproc->session;
- account = session->account;
- gc = purple_account_get_connection(account);
state = cmd->params[1];
passport = cmd->params[2];
@@ -1246,8 +1233,6 @@ nln_cmd(MsnCmdProc *cmdproc, MsnCommand
nln_cmd(MsnCmdProc *cmdproc, MsnCommand *cmd)
{
MsnSession *session;
- PurpleAccount *account;
- PurpleConnection *gc;
MsnUser *user;
MsnObject *msnobj;
unsigned long clientid, extcaps;
@@ -1256,8 +1241,6 @@ nln_cmd(MsnCmdProc *cmdproc, MsnCommand
const char *state, *passport, *friendly;
session = cmdproc->session;
- account = session->account;
- gc = purple_account_get_connection(account);
state = cmd->params[0];
passport = cmd->params[1];
@@ -1455,7 +1438,7 @@ rng_cmd(MsnCmdProc *cmdproc, MsnCommand
swboard = msn_switchboard_new(session);
msn_switchboard_set_invited(swboard, TRUE);
- msn_switchboard_set_session_id(swboard, cmd->params[0]);
+ msn_switchboard_set_session_id(swboard, session_id);
msn_switchboard_set_auth_key(swboard, cmd->params[3]);
swboard->im_user = g_strdup(cmd->params[4]);
/* msn_switchboard_add_user(swboard, cmd->params[4]); */
@@ -1696,14 +1679,12 @@ ubx_cmd_post(MsnCmdProc *cmdproc, MsnCom
size_t len)
{
MsnSession *session;
- PurpleAccount *account;
MsnUser *user;
const char *passport;
xmlnode *payloadNode;
char *psm_str, *str;
session = cmdproc->session;
- account = session->account;
passport = cmd->params[0];
if (g_str_equal(passport, session->user->passport))
============================================================
--- libpurple/protocols/msn/slp.c 8831be64dcf10688e96b2fbd30af6698e3571236
+++ libpurple/protocols/msn/slp.c 8d9b3e8f9a88515a7e9ff1addc065fe800d901c3
@@ -118,7 +118,6 @@ got_user_display(MsnSlpCall *slpcall,
got_user_display(MsnSlpCall *slpcall,
const guchar *data, gsize size)
{
- MsnUserList *userlist;
const char *info;
PurpleAccount *account;
@@ -128,7 +127,6 @@ got_user_display(MsnSlpCall *slpcall,
if (purple_debug_is_verbose())
purple_debug_info("msn", "Got User Display: %s\n", slpcall->slplink->remote_user);
- userlist = slpcall->slplink->session->userlist;
account = slpcall->slplink->session->account;
purple_buddy_icons_set_for_user(account, slpcall->slplink->remote_user,
============================================================
--- libpurple/protocols/msn/userlist.c 835799cb17ad0ab61f74290d58a21764fe43cef0
+++ libpurple/protocols/msn/userlist.c 4c69deea85c096a7eb99bf90fc47b487cfa82bbd
@@ -699,8 +699,6 @@ msn_release_buddy_icon_request(MsnUserLi
if (userlist->buddy_icon_window > 0) {
GQueue *queue;
- PurpleAccount *account;
- const char *username;
queue = userlist->buddy_icon_requests;
@@ -709,9 +707,6 @@ msn_release_buddy_icon_request(MsnUserLi
user = g_queue_pop_head(queue);
- account = userlist->session->account;
- username = user->passport;
-
userlist->buddy_icon_window--;
msn_request_user_display(user);
More information about the Commits
mailing list