pidgin: 155c91a4: Prevent a use-after-free. The timeout_cb...

qulogic at pidgin.im qulogic at pidgin.im
Sun Nov 21 05:07:39 EST 2010


----------------------------------------------------------------------
Revision: 155c91a4c60106b35cf346ccf4645e2eac7a40bc
Parent:   dae066f644c6889a92dbe25067e635747c28a900
Author:   qulogic at pidgin.im
Date:     11/21/10 01:58:45
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/155c91a4c60106b35cf346ccf4645e2eac7a40bc

Changelog: 

Prevent a use-after-free. The timeout_cb may free the MsnTransaction,
so we can't use it after that.

Changes against parent dae066f644c6889a92dbe25067e635747c28a900

  patched  libpurple/protocols/msn/transaction.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/transaction.c	6226528992fb7236c3df44e4e3a787688a52ec2e
+++ libpurple/protocols/msn/transaction.c	696043363e4025a1c30f14265b9b7e6682dc6656
@@ -220,10 +220,11 @@ transaction_timeout(gpointer data)
 	purple_debug_info("msn", "timed out: %s %d %s\n", trans->command, trans->trId, trans->params);
 #endif
 
+	trans->timer = 0;
+
 	if (trans->timeout_cb != NULL)
 		trans->timeout_cb(trans->cmdproc, trans);
 
-	trans->timer = 0;
 	return FALSE;
 }
 


More information about the Commits mailing list