pidgin: dae066f6: Don't attempt to process zero-length DC ...

qulogic at pidgin.im qulogic at pidgin.im
Sun Nov 21 05:07:48 EST 2010


----------------------------------------------------------------------
Revision: dae066f644c6889a92dbe25067e635747c28a900
Parent:   948d8c81d2ca8b6a8284f310764c5ee0f394228e
Author:   qulogic at pidgin.im
Date:     11/20/10 19:53:26
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/dae066f644c6889a92dbe25067e635747c28a900

Changelog: 

Don't attempt to process zero-length DC messages. We should probably
just use these for acking or something.

Fixes #12660.

Changes against parent 948d8c81d2ca8b6a8284f310764c5ee0f394228e

  patched  libpurple/protocols/msn/directconn.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/directconn.c	e70ada586d29a3c2a8dcac55b00a2f77adff6a25
+++ libpurple/protocols/msn/directconn.c	58775caeb9861aa36c95f2a2af61335a90c8518a
@@ -630,8 +630,10 @@ msn_dc_process_packet(MsnDirectConn *dc,
 
 	case DC_STATE_ESTABLISHED:
 
-		part = msn_slpmsgpart_new_from_data(dc->in_buffer + 4, dc->header.length);
-		msn_slplink_process_msg(dc->slplink, part);
+		if (dc->header.length) {
+			part = msn_slpmsgpart_new_from_data(dc->in_buffer + 4, dc->header.length);
+			msn_slplink_process_msg(dc->slplink, part);
+		}
 
 		/*
 		if (dc->num_calls == 0) {


More information about the Commits mailing list