pidgin: 57238053: Fix the possible leak in the function th...

qulogic at pidgin.im qulogic at pidgin.im
Sun Nov 21 22:10:57 EST 2010


----------------------------------------------------------------------
Revision: 572380531f1918ab47ff6a6dcca804bd8be42adf
Parent:   9bb29a1cd8ca54c0d833778f0c3263e76cae4ab6
Author:   qulogic at pidgin.im
Date:     11/21/10 21:39:10
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/572380531f1918ab47ff6a6dcca804bd8be42adf

Changelog: 

Fix the possible leak in the function that's actually used.

Changes against parent 9bb29a1cd8ca54c0d833778f0c3263e76cae4ab6

  patched  libpurple/protocols/msn/slpmsg_part.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/slpmsg_part.c	61b8314f8b0be2f3c387b36abdb740880939e5a9
+++ libpurple/protocols/msn/slpmsg_part.c	c2109bde46a65c772b20e23c876a75f1af755d7a
@@ -28,13 +28,13 @@ MsnSlpMessagePart *msn_slpmsgpart_new_fr
 	const char *tmp;
 	int body_len;
 
-	tmp = data;
-	part = msn_slpmsgpart_new(NULL, NULL);
-
 	if (data_len < sizeof(*header)) {
 		return NULL;
 	}
 
+	part = msn_slpmsgpart_new(NULL, NULL);
+	tmp = data;
+
 	/* Extract the binary SLP header */
 	part->header = msn_p2p_header_from_wire((MsnP2PHeader*)tmp);
 	tmp += P2P_PACKET_HEADER_SIZE;


More information about the Commits mailing list