pidgin: aa3b9562: Quote the path for the windows "run at s...

datallah at pidgin.im datallah at pidgin.im
Tue Oct 26 14:56:43 EDT 2010


----------------------------------------------------------------------
Revision: aa3b95627ddc76842b7b33f30bce406d7a689dd8
Parent:   82e935b340047646fa99de444cd143a4523928cc
Author:   datallah at pidgin.im
Date:     10/26/10 14:52:56
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/aa3b95627ddc76842b7b33f30bce406d7a689dd8

Changelog: 

Quote the path for the windows "run at startup" registry key.
The only reason it ever worked like it was is that MS apparently has some wacky
fallbacks that makes it find stuff in the Program Files folder when it sees a
directory called "Program".
Thanks to Christian Lange for noticing and tracking down the problem.
Fixes #12781

Changes against parent 82e935b340047646fa99de444cd143a4523928cc

  patched  pidgin/plugins/win32/winprefs/winprefs.c

-------------- next part --------------
============================================================
--- pidgin/plugins/win32/winprefs/winprefs.c	60d5f0696286ee271a94a3371773db69463209e4
+++ pidgin/plugins/win32/winprefs/winprefs.c	17198b14d8def7349aaeb3093f32fe23304a6498
@@ -193,7 +193,7 @@ winprefs_set_autostart(GtkWidget *w) {
 	char *runval = NULL;
 
 	if(gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(w)))
-		runval = g_strdup_printf("%s" G_DIR_SEPARATOR_S "pidgin.exe", wpurple_install_dir());
+		runval = g_strdup_printf("\"%s" G_DIR_SEPARATOR_S "pidgin.exe\"", wpurple_install_dir());
 
 	if(!wpurple_write_reg_string(HKEY_CURRENT_USER, RUNKEY, "Pidgin", runval)
 		/* For Win98 */
@@ -267,15 +267,16 @@ static GtkWidget* get_config_frame(Purpl
 }
 
 static GtkWidget* get_config_frame(PurplePlugin *plugin) {
-	GtkWidget *ret;
-	GtkWidget *vbox;
-	GtkWidget *button;
+	GtkWidget *ret, *vbox, *button, *language_sel;
 	char *run_key_val;
 	char *tmp;
 
 	ret = gtk_vbox_new(FALSE, 18);
 	gtk_container_set_border_width(GTK_CONTAINER(ret), 12);
 
+	vbox = pidgin_make_frame(ret, _("Language"));
+	language_sel = gtk_option_menu_new();
+
 	/* Autostart */
 	vbox = pidgin_make_frame(ret, _("Startup"));
 	tmp = g_strdup_printf(_("_Start %s on Windows startup"), PIDGIN_NAME);


More information about the Commits mailing list