pidgin: 9bb423c0: jabber: Partial revert (everything but C...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sun Sep 19 20:57:45 EDT 2010


----------------------------------------------------------------------
Revision: 9bb423c075e503083363981f5e96b3ad800182fd
Parent:   e1119abd5c3f78ae3b17c3a20ecb37d5ef001385
Author:   darkrain42 at pidgin.im
Date:     09/19/10 20:51:21
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/9bb423c075e503083363981f5e96b3ad800182fd

Changelog: 

jabber: Partial revert (everything but ChangeLog) of 945ef5abc5

It causes issues with non-GAfyD accounts associated with arbitrary
email addresses (since Google lets the user auth with that email
and then changes the JID to be "@gmail.com").  Fixes #a14153

Changes against parent e1119abd5c3f78ae3b17c3a20ecb37d5ef001385

  patched  ChangeLog
  patched  libpurple/protocols/jabber/auth_cyrus.c
  patched  libpurple/protocols/jabber/auth_plain.c

-------------- next part --------------
============================================================
--- ChangeLog	a5f4cb171b961c5704a111d6c0021c682455ed1b
+++ ChangeLog	fdb9ce08f2e43e7feda94510fdc5908a9e637155
@@ -24,9 +24,9 @@ version 2.7.4 (MM/DD/YYYY):
 	* Add Google Chrome to the list of possible browsers on non-Windows
 	  systems.
 	* Add Chromium to the list of possible browsers on non-Windows systems.
-	* The "Manual" browser option is now stored as a string.  It is no longer
-	  necessary to specify a full path to the browser command. (rtobar)
-	  (#12024)
+	* The "Manual" browser option is now stored as a string.  It is no
+	  longer necessary to specify a full path to the browser command.
+	  (rtobar) (#12024)
 	* The Send To menu can now be used if the active account in the
 	  conversation becomes disabled or inactive. (Keith Moyer) (#12471)
 
@@ -44,6 +44,11 @@ version 2.7.4 (MM/DD/YYYY):
 	* Added support for using Google's relay servers when making voice and
 	  video calls to Google clients.
 	* Fix detecting file transfer proxies advertised by the server.
+	* Advertise support for Google Talk's JID Domain Discovery extension
+	  in all cases again (changed in 2.7.0), not just when the domain
+	  is "gmail.com" or "googlemail.com" (it's also needed for Google
+	  Talk used for accounts on arbitrary domains not using Google Apps
+	  for Your Domain). (#a14153)
 
 	Yahoo/Yahoo JAPAN:
 	* Stop doing unnecessary lookups of certain alias information.  This
============================================================
--- libpurple/protocols/jabber/auth_cyrus.c	d2bfd74ef5947eedc6fc7b489e53cf43b57f6f41
+++ libpurple/protocols/jabber/auth_cyrus.c	66c8538d1410b3e5320daef818adddc6abe931a3
@@ -321,11 +321,8 @@ jabber_auth_start_cyrus(JabberStream *js
 		xmlnode_set_namespace(auth, NS_XMPP_SASL);
 		xmlnode_set_attrib(auth, "mechanism", js->current_mech);
 
-		if (g_str_equal(js->user->domain, "gmail.com") ||
-				g_str_equal(js->user->domain, "googlemail.com")) {
-			xmlnode_set_attrib(auth, "xmlns:ga", "http://www.google.com/talk/protocol/auth");
-			xmlnode_set_attrib(auth, "ga:client-uses-full-bind-result", "true");
-		}
+		xmlnode_set_attrib(auth, "xmlns:ga", "http://www.google.com/talk/protocol/auth");
+		xmlnode_set_attrib(auth, "ga:client-uses-full-bind-result", "true");
 
 		if (clientout) {
 			if (coutlen == 0) {
============================================================
--- libpurple/protocols/jabber/auth_plain.c	0cea8f0272a4cdf948cde0ecc7fc631b3a9754c9
+++ libpurple/protocols/jabber/auth_plain.c	65a514154d52ad5ff95bd2d8055bef78902ae042
@@ -40,11 +40,8 @@ static xmlnode *finish_plaintext_authent
 	auth = xmlnode_new("auth");
 	xmlnode_set_namespace(auth, NS_XMPP_SASL);
 
-	if (g_str_equal(js->user->domain, "gmail.com") ||
-			g_str_equal(js->user->domain, "googlemail.com")) {
-		xmlnode_set_attrib(auth, "xmlns:ga", "http://www.google.com/talk/protocol/auth");
-		xmlnode_set_attrib(auth, "ga:client-uses-full-bind-result", "true");
-	}
+	xmlnode_set_attrib(auth, "xmlns:ga", "http://www.google.com/talk/protocol/auth");
+	xmlnode_set_attrib(auth, "ga:client-uses-full-bind-result", "true");
 
 	response = g_string_new("");
 	response = g_string_append_c(response, '\0');


More information about the Commits mailing list