4a52a50f: In purple_buddy_icons_set_account_icon, ...

markdoliner at markdoliner at
Tue Apr 12 20:25:48 EDT 2011

Revision: 4a52a50f8f206adb4244972c752a72885866683a
Parent:   aac4b2ccb83ecefa913ba620070f963134ede35c
Author:   markdoliner at
Date:     04/12/11 20:16:51


In purple_buddy_icons_set_account_icon, call the prpl's set_buddy_icon
function if the account is in the connecting state (not just connected).
I believe this is the polite thing to do.

I'm seeing a little race condition in the jabber prpl where if the user
changes their icon while the account is connecting, the new icon isn't
set.  This is one half of the fix.

I don't _think_ this will cause problems.  It's possible that some
prpls will be unhappy if a user tries to set an icon while the account
is connecting.  If those problems exist, I think they should be fixed
in each prpl.

Changes against parent aac4b2ccb83ecefa913ba620070f963134ede35c

  patched  libpurple/buddyicon.c

-------------- next part --------------
--- libpurple/buddyicon.c	a2fa9803756be3f0772326767df5d54667f5613f
+++ libpurple/buddyicon.c	125bc4c1e95593c9219b287fd84278a6544265f0
@@ -756,7 +756,7 @@ purple_buddy_icons_set_account_icon(Purp
 		g_hash_table_remove(pointer_icon_cache, account);
-	if (purple_account_is_connected(account))
+	if (!purple_account_is_disconnected(account))
 		PurpleConnection *gc;
 		PurplePluginProtocolInfo *prpl_info;

More information about the Commits mailing list