pidgin: 9eec46fa: Bj?rn Voigt pointed out that my plugin i...
rekkanoryo at pidgin.im
rekkanoryo at pidgin.im
Sat Aug 6 00:57:18 EDT 2011
----------------------------------------------------------------------
Revision: 9eec46fa89b0482a6bd6d352066f67e679c58707
Parent: dcc8e1d14b41f29a248ddf04ed3c395eba1bcc5e
Author: rekkanoryo at pidgin.im
Date: 08/06/11 00:52:18
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/9eec46fa89b0482a6bd6d352066f67e679c58707
Changelog:
Bj?rn Voigt pointed out that my plugin info dialog doesn't show the e-mail
addresses included in plugins' author strings. This should fix that. I opted
to escape the plugin's name too because I recall seeing a plugin with characters
in its displayed name that would need to be escaped to display in the dialog.
Fixes <4E353E4E.3040707 at chemnitz.dialup.cs.tu-berlin.de>.
Changes against parent dcc8e1d14b41f29a248ddf04ed3c395eba1bcc5e
patched pidgin/gtkdialogs.c
-------------- next part --------------
============================================================
--- pidgin/gtkdialogs.c f8d5e43e624a7b5a913110e5ff4f1a16ea305b0f
+++ pidgin/gtkdialogs.c a47dd6f786a5d58210d092d2696aae6e8cf983c4
@@ -794,7 +794,8 @@ void pidgin_dialogs_plugins_info(void)
GList *l = NULL;
PurplePlugin *plugin = NULL;
char *title = g_strdup_printf(_("%s Plugin Information"), PIDGIN_NAME);
- const char *pname, *pauthor, *pver, *pwebsite, *pid;
+ char *pname = NULL, *pauthor = NULL;
+ const char *pver, *pwebsite, *pid;
gboolean ploaded, punloadable;
static GtkWidget *plugins_info = NULL;
@@ -806,8 +807,8 @@ void pidgin_dialogs_plugins_info(void)
for(l = purple_plugins_get_all(); l; l = l->next) {
plugin = (PurplePlugin *)l->data;
- pname = purple_plugin_get_name(plugin);
- pauthor = purple_plugin_get_author(plugin);
+ pname = g_markup_escape_text(purple_plugin_get_name(plugin), -1);
+ pauthor = g_markup_escape_text(purple_plugin_get_author(plugin), -1);
pver = purple_plugin_get_version(plugin);
pwebsite = purple_plugin_get_homepage(plugin);
pid = purple_plugin_get_id(plugin);
@@ -829,6 +830,8 @@ void pidgin_dialogs_plugins_info(void)
g_signal_connect(G_OBJECT(plugins_info), "destroy",
G_CALLBACK(gtk_widget_destroyed), &plugins_info);
g_free(title);
+ g_free(pname);
+ g_free(pauthor);
}
static void
More information about the Commits
mailing list