pidgin: 7a7537a5: Almost certainly not an issue, but bound...

elb at pidgin.im elb at pidgin.im
Thu Aug 11 12:42:10 EDT 2011


----------------------------------------------------------------------
Revision: 7a7537a58570b401e5101a0f066f4e394b08661b
Parent:   2da481797f1fc051a8d4f9c331528a3e4245e529
Author:   elb at pidgin.im
Date:     08/11/11 12:13:15
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/7a7537a58570b401e5101a0f066f4e394b08661b

Changelog: 

Almost certainly not an issue, but bounds check a strcpy in stun.c (EFF)

Changes against parent 2da481797f1fc051a8d4f9c331528a3e4245e529

  patched  libpurple/stun.c

-------------- next part --------------
============================================================
--- libpurple/stun.c	e856545d1fac9bbaab3fa6f32f2b84fe4b013220
+++ libpurple/stun.c	f22c2ce3d2d7f5c685f889a4602c910ae6e19945
@@ -226,7 +226,7 @@ static void reply_cb(gpointer data, gint
 				memcpy(&in.s_addr, tmp + 4, 4);
 				ip = inet_ntoa(in);
 				if(ip)
-					strcpy(nattype.publicip, ip);
+					g_strlcpy(nattype.publicip, ip, sizeof(nattype.publicip));
 			}
 
 			tmp += ntohs(attrib->len);


More information about the Commits mailing list