pidgin: 29c6bcad: Fix potential crash when NAMES is empty.

elb at pidgin.im elb at pidgin.im
Tue Aug 16 13:16:17 EDT 2011


----------------------------------------------------------------------
Revision: 29c6bcad8375eb01e1dff0f135c6cbd34dd20380
Parent:   a8f7d30ad8a5756712d86d00f6ba708dd7f54340
Author:   jamie at lacewing-project.org
Date:     08/16/11 13:11:39
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/29c6bcad8375eb01e1dff0f135c6cbd34dd20380

Changelog: 

Fix potential crash when NAMES is empty.

Fixes #14518

Changes against parent a8f7d30ad8a5756712d86d00f6ba708dd7f54340

  patched  COPYRIGHT
  patched  ChangeLog
  patched  libpurple/protocols/irc/msgs.c

-------------- next part --------------
============================================================
--- ChangeLog	9ac5bdb331f3d7dcb974598fc0d6ce7163b2469e
+++ ChangeLog	57d67b323330fa1875e1c4ef7bef443164957480
@@ -33,6 +33,7 @@ version 2.10.0 (MM/DD/YYYY):
 	ICQ:
 	* Fix crash selecting Tools->Set Mood when you're online with an
 	  ICQ account that is configured as an AIM account. (#14437)
+	* Fix crash when NAMES is empty. (James McLaughlin) (#14518)
 
 	IRC:
 	* Fix the handling of formatting following mIRC ^O (#14436)
============================================================
--- libpurple/protocols/irc/msgs.c	8283ab2a8ceb33c47483e07df22950319b0beac3
+++ libpurple/protocols/irc/msgs.c	0d5069b55dac6af2b9b74c8745963c2f96e8a7e0
@@ -587,7 +587,7 @@ void irc_msg_names(struct irc_conn *irc,
 			else
 				purple_conv_im_write(PURPLE_CONV_IM(convo), "", msg, PURPLE_MESSAGE_SYSTEM|PURPLE_MESSAGE_NO_LOG, time(NULL));
 			g_free(msg);
-		} else {
+		} else if (cur != NULL) {
 			GList *users = NULL;
 			GList *flags = NULL;
 
============================================================
--- COPYRIGHT	65f8e9208fb744ce39b128dc83cc169e0c0a62e7
+++ COPYRIGHT	ac32c81db327a1c5a9d1e57c06ed3ca5337b374f
@@ -332,6 +332,7 @@ Kurt McKee
 Ryan McCabe
 Peter McCurdy
 Kurt McKee
+James McLaughlin
 Torrey McMahon
 Greg McNew
 Robert McQueen


More information about the Commits mailing list