pidgin: 16af0661: Fix incorrect handling of HTTP 100 respo...

markdoliner at pidgin.im markdoliner at pidgin.im
Sat Aug 20 13:05:57 EDT 2011


----------------------------------------------------------------------
Revision: 16af0661899a978b4fedc1c165965b85009013d1
Parent:   5c2dba4a7e2e76b76e7f472b88953a4316706d43
Author:   markdoliner at pidgin.im
Date:     08/18/11 04:45:22
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/16af0661899a978b4fedc1c165965b85009013d1

Changelog: 

Fix incorrect handling of HTTP 100 responses when using the HTTP
connection method.  This can lead to a crash. (Discovered by Marius
Wachtler)

Changes against parent 5c2dba4a7e2e76b76e7f472b88953a4316706d43

  patched  ChangeLog
  patched  libpurple/protocols/msn/httpconn.c

-------------- next part --------------
============================================================
--- ChangeLog	dad909df951e4b1fa589b904da36d0341f0340e7
+++ ChangeLog	7f3083754856b067e78b1d4e54b3ff1d63fdf041
@@ -41,6 +41,9 @@ version 2.10.0 (08/18/2011):
 	* Fix crash when NAMES is empty. (James McLaughlin) (#14518)
 
 	MSN:
+	* Fix incorrect handling of HTTP 100 responses when using the HTTP
+	  connection method.  This can lead to a crash. (Discovered by Marius
+	  Wachtler)
 	* Fix seemingly random crashing. (#14307)
 	* Fix a crash when the account is disconnected at the time we are doing a
 	  SB request. (Hanzz, ported by shlomif) (#12431)
============================================================
--- libpurple/protocols/msn/httpconn.c	6bfb5c975be23a647a5f61f0e15174adddb30ea6
+++ libpurple/protocols/msn/httpconn.c	eb77536bdfa7a2901f12fc98a106a165687936c2
@@ -111,8 +111,8 @@ msn_httpconn_parse_data(MsnHttpConn *htt
 			return TRUE;
 		}
 
+		size -= (s - buf);
 		buf = s;
-		size -= (s - buf);
 	}
 
 	if ((s = strstr(buf, "\r\n\r\n")) == NULL)


More information about the Commits mailing list