pidgin: cd7e0618: These should be using purple_notify_user...
andrew.victor at mxit.com
andrew.victor at mxit.com
Mon Aug 22 18:16:01 EDT 2011
----------------------------------------------------------------------
Revision: cd7e0618fa45ee113bac1516e7f907b02c79219a
Parent: 5da91575f92c8c13d7a85eef338ec6da55e6fb26
Author: andrew.victor at mxit.com
Date: 08/22/11 18:09:55
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/cd7e0618fa45ee113bac1516e7f907b02c79219a
Changelog:
These should be using purple_notify_user_info_add_pair_plaintext().
Changes against parent 5da91575f92c8c13d7a85eef338ec6da55e6fb26
patched libpurple/protocols/mxit/mxit.c
patched libpurple/protocols/mxit/profile.c
-------------- next part --------------
============================================================
--- libpurple/protocols/mxit/mxit.c 99e0162713a147af741a4144d309ec5183c4b4f7
+++ libpurple/protocols/mxit/mxit.c a8f4ec32f53ec29d6e4e9b1eb6ae9a4a822fafeb
@@ -358,11 +358,8 @@ static void mxit_tooltip( PurpleBuddy* b
purple_notify_user_info_add_pair_plaintext( info, _( "Subscription" ), mxit_convert_subtype_to_name( contact->subtype ) );
/* rejection message */
- if ( ( contact->subtype == MXIT_SUBTYPE_REJECTED ) && ( contact->msg != NULL ) ) {
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Rejection Message" ), contact->msg );
- }
+ if ( ( contact->subtype == MXIT_SUBTYPE_REJECTED ) && ( contact->msg != NULL ) )
+ purple_notify_user_info_add_pair_plaintext( info, _( "Rejection Message" ), contact->msg );
}
============================================================
--- libpurple/protocols/mxit/profile.c 375d93aaa6c0af1240775ce33043916b4e0e0d8d
+++ libpurple/protocols/mxit/profile.c de4a344e1843e7f388350fcb3582222715ce99ef
@@ -175,40 +175,26 @@ void mxit_show_profile( struct MXitSessi
contact = purple_buddy_get_protocol_data( buddy );
}
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Display Name" ), profile->nickname );
+ purple_notify_user_info_add_pair_plaintext( info, _( "Display Name" ), profile->nickname );
tmp = g_strdup_printf("%s (%i)", profile->birthday, calculateAge( profile->birthday ) );
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Birthday" ), tmp );
+ purple_notify_user_info_add_pair_plaintext( info, _( "Birthday" ), tmp );
g_free( tmp );
purple_notify_user_info_add_pair_plaintext( info, _( "Gender" ), profile->male ? _( "Male" ) : _( "Female" ) );
/* optional information */
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "First Name" ), profile->firstname );
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Last Name" ), profile->lastname );
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Country" ), profile->regcountry );
+ purple_notify_user_info_add_pair_plaintext( info, _( "First Name" ), profile->firstname );
+ purple_notify_user_info_add_pair_plaintext( info, _( "Last Name" ), profile->lastname );
- if ( *profile->aboutme ) {
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "About Me" ), profile->aboutme );
- }
- if ( *profile->whereami ) {
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Where I Live" ), profile->whereami );
- }
+ purple_notify_user_info_add_pair_plaintext( info, _( "Country" ), profile->regcountry );
+ if ( *profile->aboutme )
+ purple_notify_user_info_add_pair_plaintext( info, _( "About Me" ), profile->aboutme );
+
+ if ( *profile->whereami )
+ purple_notify_user_info_add_pair_plaintext( info, _( "Where I Live" ), profile->whereami );
+
purple_notify_user_info_add_section_break( info );
if ( contact ) {
@@ -241,11 +227,8 @@ void mxit_show_profile( struct MXitSessi
if ( contact ) {
/* invite found */
- if ( contact->msg ) {
- /* TODO: Check whether it's correct to call add_pair_html,
- or if we should be using add_pair_plaintext */
- purple_notify_user_info_add_pair_html( info, _( "Invite Message" ), contact->msg );
- }
+ if ( contact->msg )
+ purple_notify_user_info_add_pair_plaintext( info, _( "Invite Message" ), contact->msg );
if ( contact->imgid ) {
/* this invite has a avatar */
More information about the Commits
mailing list