pidgin.2.x.y: a3c911b6: Fix parameter types passed to ShellExecu...

datallah at datallah at
Wed Aug 24 11:41:02 EDT 2011

Revision: a3c911b63a6bec656108e0a50da6a7ad325558ec
Parent:   218f7cd8f439bacd4fef6897f0389a7cd18ba67d
Author:   datallah at
Date:     08/24/11 11:05:10
Branch:   im.pidgin.pidgin.2.x.y


Fix parameter types passed to ShellExecuteW().  One of these is just a warning
fix, the other is potentially a problem.  I'm not sure what ShellExecuteW()
will do with "OPEN" vs. L"OPEN" - probably execute the default action which is
also L"OPEN".

Changes against parent 218f7cd8f439bacd4fef6897f0389a7cd18ba67d

  patched  pidgin/gtkutils.c

-------------- next part --------------
--- pidgin/gtkutils.c	ddbb37297ab32b153a1aca4b28787e1c883ad907
+++ pidgin/gtkutils.c	4d9e9060bef0c4831ffffbbd3db155e98f48280a
@@ -3286,9 +3286,9 @@ file_open_uri(GtkIMHtml *imhtml, const c
 		gchar *escaped = g_shell_quote(uri);
 		gchar *param = g_strconcat("/select,\"", uri, "\"", NULL);
-		gchar *wc_param = g_utf8_to_utf16(param, -1, NULL, NULL, NULL);
+		wchar_t *wc_param = g_utf8_to_utf16(param, -1, NULL, NULL, NULL);
-		code = (int)ShellExecuteW(NULL, "OPEN", L"explorer.exe", wc_param, NULL, SW_NORMAL);
+		code = (int)ShellExecuteW(NULL, L"OPEN", L"explorer.exe", wc_param, NULL, SW_NORMAL);

More information about the Commits mailing list