pidgin: 1c254499: Fix two compile warnings. Did I do that...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Aug 26 01:07:59 EDT 2011


----------------------------------------------------------------------
Revision: 1c25449999635cbf756f93ea8784b17eb37ce18e
Parent:   a0ad05d0a632c50d6f34e8c6408a7240fe9ffa43
Author:   markdoliner at pidgin.im
Date:     08/26/11 01:00:46
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/1c25449999635cbf756f93ea8784b17eb37ce18e

Changelog: 

Fix two compile warnings.  Did I do that?  I totally didn't notice.  My bad.

roomlist.c: In function 'purple_roomlist_room_get_expanded_once':
roomlist.c:402:2: warning: return makes integer from pointer without a cast
roomlist.c: In function 'purple_roomlist_room_set_expanded_once':
roomlist.c:409:2: warning: 'return' with a value, in function returning void

Changes against parent a0ad05d0a632c50d6f34e8c6408a7240fe9ffa43

  patched  libpurple/roomlist.c

-------------- next part --------------
============================================================
--- libpurple/roomlist.c	04b60f0d85d7808c453b69ccdbc83d4d8df840e3
+++ libpurple/roomlist.c	2f2565304f822914d9ba0d9dd912f9c715b69e92
@@ -399,14 +399,14 @@ gboolean purple_roomlist_room_get_expand
 
 gboolean purple_roomlist_room_get_expanded_once(PurpleRoomlistRoom *room)
 {
-	g_return_val_if_fail(room != NULL, NULL);
+	g_return_val_if_fail(room != NULL, FALSE);
 
 	return room->expanded_once;
 }
 
 void purple_roomlist_room_set_expanded_once(PurpleRoomlistRoom *room, gboolean expanded_once)
 {
-	g_return_val_if_fail(room != NULL, NULL);
+	g_return_if_fail(room != NULL);
 
 	room->expanded_once = expanded_once;
 }


More information about the Commits mailing list