pidgin: 8c46635c: The function gst_msg_db_to_percent alrea...

qulogic at pidgin.im qulogic at pidgin.im
Thu Dec 22 04:41:40 EST 2011


----------------------------------------------------------------------
Revision: 8c46635caa338dd5b17c52f91567d10cf23c7af9
Parent:   1270f4e5ab858ed24cdaf179e71fedea82ea9e09
Author:   qulogic at pidgin.im
Date:     12/21/11 23:27:59
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/8c46635caa338dd5b17c52f91567d10cf23c7af9

Changelog: 

The function gst_msg_db_to_percent already retyrns a number between
0.0 and 1.0, and a GtkProgressBar is between 0.0 and 1.0, so I don't
know why the level is multiplied by 5. Maybe microphones aren't that
loud? I expect the "volume" control to increase it, so I'm not so
sure. I guess we'll see what people think.

Fixes #14426.

Changes against parent 1270f4e5ab858ed24cdaf179e71fedea82ea9e09

  patched  pidgin/gtkmedia.c
  patched  pidgin/plugins/vvconfig.c

-------------- next part --------------
============================================================
--- pidgin/gtkmedia.c	0d9caba0df761102c343430e17331d8a55d2d5ef
+++ pidgin/gtkmedia.c	fae07cea1c0fb4e5268841bb5e16b13e63840491
@@ -455,7 +455,7 @@ level_message_cb(PurpleMedia *media, gch
 		progress = pidgin_media_get_widget(gtkmedia, session_id, participant);
 
 	if (progress)
-		gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), level * 5);
+		gtk_progress_bar_set_fraction(GTK_PROGRESS_BAR(progress), level);
 }
 
 
============================================================
--- pidgin/plugins/vvconfig.c	6fff312787e23744082a99068004bc2038b41a5a
+++ pidgin/plugins/vvconfig.c	35c05ca46f900348c75ff1c3087825032f8a8913
@@ -612,7 +612,7 @@ gst_bus_cb(GstBus *bus, GstMessage *msg,
 			GstElement *valve;
 
 			percent = gst_msg_db_to_percent(msg, "rms");
-			gtk_progress_bar_set_fraction(ctx->level, percent * 5);
+			gtk_progress_bar_set_fraction(ctx->level, percent);
 
 			percent = gst_msg_db_to_percent(msg, "decay");
 			threshold = gtk_range_get_value(ctx->threshold) / 100.0;


More information about the Commits mailing list