pidgin: 16f4c309: Fix a potential information leak in ciph...
rekkanoryo at pidgin.im
rekkanoryo at pidgin.im
Sun Feb 6 23:35:44 EST 2011
----------------------------------------------------------------------
Revision: 16f4c309528b82961b169edb8b74b9061db6c471
Parent: 4b89bcd9801d10b726f0666775b4dfcfd18a206d
Author: julia at diku.dk
Date: 02/03/11 20:38:51
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/16f4c309528b82961b169edb8b74b9061db6c471
Changelog:
Fix a potential information leak in cipher.c.
Changes against parent 4b89bcd9801d10b726f0666775b4dfcfd18a206d
patched libpurple/cipher.c
-------------- next part --------------
============================================================
--- libpurple/cipher.c bde0d8015b38fe31bbf5c8abe4c8b0b88ee37ab0
+++ libpurple/cipher.c 65cd01499cf781de8dde923013ee0e25b736a67e
@@ -249,7 +249,7 @@ md5_uninit(PurpleCipherContext *context)
purple_cipher_context_reset(context, NULL);
md5_context = purple_cipher_context_get_data(context);
- memset(md5_context, 0, sizeof(md5_context));
+ memset(md5_context, 0, sizeof(*md5_context));
g_free(md5_context);
md5_context = NULL;
@@ -705,7 +705,7 @@ md4_uninit(PurpleCipherContext *context)
purple_cipher_context_reset(context, NULL);
md4_context = purple_cipher_context_get_data(context);
- memset(md4_context, 0, sizeof(md4_context));
+ memset(md4_context, 0, sizeof(*md4_context));
g_free(md4_context);
md4_context = NULL;
@@ -1356,7 +1356,7 @@ des_uninit(PurpleCipherContext *context)
struct _des_ctx *des_context;
des_context = purple_cipher_context_get_data(context);
- memset(des_context, 0, sizeof(des_context));
+ memset(des_context, 0, sizeof(*des_context));
g_free(des_context);
des_context = NULL;
@@ -1706,7 +1706,7 @@ des3_uninit(PurpleCipherContext *context
struct _des3_ctx *des3_context;
des3_context = purple_cipher_context_get_data(context);
- memset(des3_context, 0, sizeof(des3_context));
+ memset(des3_context, 0, sizeof(*des3_context));
g_free(des3_context);
des3_context = NULL;
@@ -2382,7 +2382,7 @@ rc4_uninit(PurpleCipherContext *context)
struct RC4Context *rc4_ctx;
rc4_ctx = purple_cipher_context_get_data(context);
- memset(rc4_ctx, 0, sizeof(rc4_ctx));
+ memset(rc4_ctx, 0, sizeof(*rc4_ctx));
g_free(rc4_ctx);
rc4_ctx = NULL;
@@ -2828,7 +2828,7 @@ purple_cipher_context_destroy(PurpleCiph
if(cipher->ops && cipher->ops->uninit)
cipher->ops->uninit(context);
- memset(context, 0, sizeof(context));
+ memset(context, 0, sizeof(*context));
g_free(context);
context = NULL;
}
More information about the Commits
mailing list