pidgin: 1a878867: silc: Debug messages.

darkrain42 at pidgin.im darkrain42 at pidgin.im
Sat Feb 19 22:06:02 EST 2011


----------------------------------------------------------------------
Revision: 1a8788675b99cc6d99185050a277dd59dd6fabd0
Parent:   959e17c8be9b4839cd3de2f73135685c7c5f16d2
Author:   darkrain42 at pidgin.im
Date:     02/19/11 22:03:54
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/1a8788675b99cc6d99185050a277dd59dd6fabd0

Changelog: 

silc: Debug messages.

This code (after looking at the relevant functions in libsilc) seems
*very* fragile.  As in, it will break if you have more than one account
at a time.  I think this fragility is what's crashing chf.  Refs #13247

Changes against parent 959e17c8be9b4839cd3de2f73135685c7c5f16d2

  patched  libpurple/protocols/silc/silc.c

-------------- next part --------------
============================================================
--- libpurple/protocols/silc/silc.c	9bbc478a0189b9d191487227518ae3bac61990f5
+++ libpurple/protocols/silc/silc.c	1f285b7424f4882fa066c2d947cbafa9e09f0b50
@@ -654,6 +654,8 @@ silcpurple_close_final(gpointer *context
 {
 	SilcPurple sg = (SilcPurple)context;
 
+	purple_debug_info("silc", "Finalizing SilcPurple %p\n", sg);
+
 	silc_client_stop(sg->client, NULL, NULL);
 	silc_client_free(sg->client);
 	if (sg->sha1hash)
@@ -714,6 +716,8 @@ silcpurple_close(PurpleConnection *gc)
 #endif /* __SILC_TOOLKIT_VERSION */
 
 	purple_timeout_remove(sg->scheduler);
+
+	purple_debug_info("silc", "Scheduling destruction of SilcPurple %p\n", sg);
 	purple_timeout_add(1, (GSourceFunc)silcpurple_close_final, sg);
 }
 


More information about the Commits mailing list