pidgin: 8707e10a: Add a comment that we should eventually ...

markdoliner at pidgin.im markdoliner at pidgin.im
Mon Jan 3 14:20:42 EST 2011


----------------------------------------------------------------------
Revision: 8707e10aca1fa6ef13a2a00f24760fb2ed97f641
Parent:   fd28311b112d25ccb1bc15ffce5aa67d565b5db9
Author:   markdoliner at pidgin.im
Date:     01/03/11 14:18:07
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/8707e10aca1fa6ef13a2a00f24760fb2ed97f641

Changelog: 

Add a comment that we should eventually remove this pref

Changes against parent fd28311b112d25ccb1bc15ffce5aa67d565b5db9

  patched  libpurple/plugins/autoaccept.c

-------------- next part --------------
============================================================
--- libpurple/plugins/autoaccept.c	38cef034e928522f0890ce6e5d7f18b151f5693e
+++ libpurple/plugins/autoaccept.c	37512f63df84b95ff5d4882431512e06ddfe3605
@@ -231,6 +231,13 @@ plugin_load(PurplePlugin *plugin)
 plugin_load(PurplePlugin *plugin)
 {
 	/* migrate the old pref (we should only care if the plugin is actually *used*) */
+	/*
+	 * TODO: We should eventually call purple_prefs_remove(PREFS_STRANGER_OLD)
+	 *       to clean up after ourselves, but we don't want to do it yet
+	 *       so that we don't break users who share a .purple directory
+	 *       between old libpurple clients and new libpurple clients.
+	 *                                             --Mark Doliner, 2011-01-03
+	 */
 	if(purple_prefs_get_bool(PREF_STRANGER_OLD))
 		purple_prefs_set_int(PREF_STRANGER, FT_REJECT);
 


More information about the Commits mailing list