pidgin: 02492bf7: Using conn->current_request looks a bit ...

qulogic at pidgin.im qulogic at pidgin.im
Tue Jan 4 23:50:49 EST 2011


----------------------------------------------------------------------
Revision: 02492bf7b7b76b4c3f35457232682841eced2f18
Parent:   cf92ebce4cf16455f44423fd59b7e7fc12210704
Author:   qulogic at pidgin.im
Date:     01/04/11 18:43:40
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/02492bf7b7b76b4c3f35457232682841eced2f18

Changelog: 

Using conn->current_request looks a bit iffy here. And even if it
wasn't, this looks nicer.

Changes against parent cf92ebce4cf16455f44423fd59b7e7fc12210704

  patched  libpurple/protocols/msn/soap.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/soap.c	93f2b9ead1325d9bd6d35a46cfb61f5b02eeeea3
+++ libpurple/protocols/msn/soap.c	78fc67e20c1bb672e372557fad66498c7174b6c2
@@ -281,13 +281,14 @@ msn_soap_handle_redirect(MsnSoapConnecti
 	char *path;
 
 	if (purple_url_parse(url, &host, NULL, &path, NULL, NULL)) {
-		msn_soap_message_send_internal(conn->session, conn->current_request->message,
-			host, path, conn->current_request->secure,
-			conn->current_request->cb, conn->current_request->cb_data, TRUE);
+		MsnSoapRequest *req = conn->current_request;
+		conn->current_request = NULL;
 
-		msn_soap_request_destroy(conn->current_request, TRUE);
-		conn->current_request = NULL;
+		msn_soap_message_send_internal(conn->session, req->message, host, path,
+			req->secure, req->cb, req->cb_data, TRUE);
 
+		msn_soap_request_destroy(req, TRUE);
+
 		g_free(host);
 		g_free(path);
 


More information about the Commits mailing list