pidgin: cf92ebce: Everyone provides a callback here. Might...

qulogic at pidgin.im qulogic at pidgin.im
Tue Jan 4 23:50:53 EST 2011


----------------------------------------------------------------------
Revision: cf92ebce4cf16455f44423fd59b7e7fc12210704
Parent:   b00671a28695c8a525112a0558c2d546d6db9a48
Author:   qulogic at pidgin.im
Date:     01/04/11 18:36:56
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/cf92ebce4cf16455f44423fd59b7e7fc12210704

Changelog: 

Everyone provides a callback here. Might as well make it required.

Changes against parent b00671a28695c8a525112a0558c2d546d6db9a48

  patched  libpurple/protocols/msn/soap.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/soap.c	710f02cb4dfe1adc161c008e3d846b16d011de31
+++ libpurple/protocols/msn/soap.c	93f2b9ead1325d9bd6d35a46cfb61f5b02eeeea3
@@ -141,8 +141,7 @@ msn_soap_connection_destroy_foreach_cb(g
 {
 	MsnSoapRequest *req = item;
 
-	if (req->cb)
-		req->cb(req->message, NULL, req->cb_data);
+	req->cb(req->message, NULL, req->cb_data);
 
 	msn_soap_request_destroy(req, FALSE);
 }
@@ -269,6 +268,7 @@ msn_soap_message_send(MsnSession *sessio
 	MsnSoapCallback cb, gpointer cb_data)
 {
 	g_return_if_fail(message != NULL);
+	g_return_if_fail(cb != NULL);
 
 	msn_soap_message_send_internal(session, message, host, path, secure,
 		cb, cb_data, FALSE);


More information about the Commits mailing list