pidgin: 6daa2377: log_reader: Fix an actual crash in the Q...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Thu Jul 21 01:45:50 EDT 2011


----------------------------------------------------------------------
Revision: 6daa23777b4cc4897c32081a6a27efc0d038e00d
Parent:   fa8d775608740f34866d694c7d4fc3bd4ca23d7b
Author:   darkrain42 at pidgin.im
Date:     07/21/11 01:39:48
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/6daa23777b4cc4897c32081a6a27efc0d038e00d

Changelog: 

log_reader: Fix an actual crash in the QIP reader.

This crashes if there's at least two lines, and the
last line doesn't contain a trailing newline.

E.g: "\n<-- foo -->" written to a file.

Changes against parent fa8d775608740f34866d694c7d4fc3bd4ca23d7b

  patched  ChangeLog
  patched  libpurple/plugins/log_reader.c

-------------- next part --------------
============================================================
--- ChangeLog	272c0aec585aac0de47a9d042acdf55d0fafea04
+++ ChangeLog	2eb2bc214fac6d34133c518cb51a8660c47c466e
@@ -9,6 +9,9 @@ version 2.10.0 (MM/DD/YYYY):
 	* Fix building with GTK+ earlier than 2.14.0 (GTK+ 2.10 is still the
 	  minimum supported) (#14261)
 
+	libpurple:
+	* Fix a potential crash in the Log Reader plugin when reading QIP logs.
+
 	Gadu-Gadu:
 	* Fixed searching for buddies in public directory. (Tomasz Wasilczyk)
 	  (#5242)
============================================================
--- libpurple/plugins/log_reader.c	2f4928de87789c58bb6760beff9e4190a528ce10
+++ libpurple/plugins/log_reader.c	2228afca79fe61c04226512ef9154a170eba94f7
@@ -1901,7 +1901,7 @@ static GList *qip_logger_list(PurpleLogT
 			start_log = new_line;
 		}
 
-		if (*c) {
+		if (c && *c) {
 			/* find EOF */
 			c = strchr(c, '\n');
 			c++;


More information about the Commits mailing list