www: 5f836d98: I guess Stu did a search and replace to ...

markdoliner at pidgin.im markdoliner at pidgin.im
Fri Mar 11 00:57:04 EST 2011


----------------------------------------------------------------------
Revision: 5f836d98717ef06d6b52411499aca192b9624893
Parent:   7146d9aea9e12e49c6456ef325655e526ce64b86
Author:   markdoliner at pidgin.im
Date:     03/11/11 00:53:34
Branch:   im.pidgin.www
URL: http://d.pidgin.im/viewmtn/revision/info/5f836d98717ef06d6b52411499aca192b9624893

Changelog: 

I guess Stu did a search and replace to use <?php instead of <? everywhere.
That's fine, except in this file we use <?= tags.  This was causing this
page to throw an error 500.  Fix it by use <?php echo

Changes against parent 7146d9aea9e12e49c6456ef325655e526ce64b86

  patched  htdocs/news/security/index.php

-------------- next part --------------
============================================================
--- htdocs/news/security/index.php	879a5bfbd805d8ae8fbd151c2e44ee2e7c377adb
+++ htdocs/news/security/index.php	ba0e67cf8e89dd3d1d034b84cfda9b6fc669ca4f
@@ -612,11 +612,11 @@ for ($i = $start; $i >= $stop; $i--) {
 	$vun =& $vulnerabilities[$i];
 ?>
   <tr>
-    <td><a href="?id=<?php=$i?>"><?php=$vun['title']?></a></td>
+    <td><a href="?id=<?php echo $i ?>"><?php echo $vun['title'] ?></a></td>
 <?php
 	if (array_key_exists('cve', $vun)) {
     ?>
-    <td><a href="http://cve.mitre.org/cgi-bin/cvename.cgi?name=<?php=$vun['cve']?>"><?php=$vun['cve']?></a></td>
+    <td><a href="http://cve.mitre.org/cgi-bin/cvename.cgi?name=<?php echo $vun['cve'] ?>"><?php echo $vun['cve'] ?></a></td>
 <?php
 	} else {
     ?>
@@ -624,8 +624,8 @@ for ($i = $start; $i >= $stop; $i--) {
 <?php
 	}
     ?>
-    <td class="date"><?php=$vun['date']?></td>
-    <td><?php=$vun['fixedversion']?></td>
+    <td class="date"><?php echo $vun['date'] ?></td>
+    <td><?php echo $vun['fixedversion'] ?></td>
   </tr>
 <?php
 }
@@ -635,12 +635,12 @@ if ($start < ($total - 1)) {
 <?php
 if ($start < ($total - 1)) {
 ?>
-<a href="?offset=<?php=($offset - $max_per_page) ?>">Newer</a>
+<a href="?offset=<?php echo ($offset - $max_per_page) ?>">Newer</a>
 <?php
 }
 if ($stop > 0) {
 ?>
-<a href="?offset=<?php=($offset + $max_per_page) ?>">Older</a>
+<a href="?offset=<?php echo ($offset + $max_per_page) ?>">Older</a>
 <?php
 }
 ?>
@@ -655,12 +655,12 @@ if ($stop > 0) {
 <h1>Pidgin Security Advisory</h1>
 
 <table>
-  <tr><th>Title</th><td><?php=$vun['title']?></td></tr>
-  <tr><th>Date</th><td><?php=$vun['date']?></td></tr>
+  <tr><th>Title</th><td><?php echo $vun['title'] ?></td></tr>
+  <tr><th>Date</th><td><?php echo $vun['date'] ?></td></tr>
   <?php
 	if (array_key_exists('cve', $vun) && !empty($vun['cve'])) {
   ?>
-  <tr><th>CVE Name</th><td><a href="http://cve.mitre.org/cgi-bin/cvename.cgi?name=<?php=$vun['cve']?>"><?php=$vun['cve']?></a></td></tr>
+  <tr><th>CVE Name</th><td><a href="http://cve.mitre.org/cgi-bin/cvename.cgi?name=<?php echo $vun['cve'] ?>"><?php echo $vun['cve'] ?></a></td></tr>
   <?php
 	} else {
   ?>
@@ -668,9 +668,9 @@ if ($stop > 0) {
   <?php
 	}
   ?>
-  <tr><th>Discovered By</th><td><?php=$vun['discoveredby']?></td></tr>
-  <tr><th>Summary</th><td><?php=$vun['summary']?></td></tr>
-  <tr><th>Description</th><td><?php=$vun['description']?></td></tr>
+  <tr><th>Discovered By</th><td><?php echo $vun['discoveredby'] ?></td></tr>
+  <tr><th>Summary</th><td><?php echo $vun['summary'] ?></td></tr>
+  <tr><th>Description</th><td><?php echo $vun['description'] ?></td></tr>
 
   <?php
 	if (array_key_exists('fixrevisions', $vun) && !empty($vun['fixrevisions'])) {
@@ -682,13 +682,13 @@ if ($stop > 0) {
 			$fixrevisions .= "<a href=\"http://developer.pidgin.im/viewmtn/revision/info/$revision\">$revision</a>";
 		}
   ?>
-  <tr><th>Fixed in Revision</th><td><?php=$fixrevisions?></td></tr>
+  <tr><th>Fixed in Revision</th><td><?php echo $fixrevisions ?></td></tr>
   <?php
     }
   ?>
 
-  <tr><th>Fixed in Version</th><td><?php=$vun['fixedversion']?></td></tr>
-  <tr><th>Fix</th><td><?php=$vun['fix']?></td></tr>
+  <tr><th>Fixed in Version</th><td><?php echo $vun['fixedversion'] ?></td></tr>
+  <tr><th>Fix</th><td><?php echo $vun['fix'] ?></td></tr>
 </table>
 
 <p><a href="?offset=0">Return to Security Advisory Index</a></p>


More information about the Commits mailing list