pidgin: 8a2ad25f: finch: finch_notify_message is kinda bug...

darkrain42 at pidgin.im darkrain42 at pidgin.im
Tue May 3 01:45:47 EDT 2011


----------------------------------------------------------------------
Revision: 8a2ad25fe0712bc0d47a1229671868560599a2cd
Parent:   1b36826db40fbb402e990ddfe7f1da64c820f54f
Author:   darkrain42 at pidgin.im
Date:     05/03/11 01:42:13
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/8a2ad25fe0712bc0d47a1229671868560599a2cd

Changelog: 

finch: finch_notify_message is kinda buggy, conflating PurpleNotifyType and PurpleNotifyMsgType.

Changes against parent 1b36826db40fbb402e990ddfe7f1da64c820f54f

  patched  finch/gntnotify.c

-------------- next part --------------
============================================================
--- finch/gntnotify.c	0aa0b8de803020f52b66b32047a50d406d87840e
+++ finch/gntnotify.c	b65450342112739956f94128f4c3cdf87d9236fd
@@ -84,6 +84,10 @@ finch_notify_message(PurpleNotifyMsgType
 
 	if (secondary) {
 		GntWidget *msg;
+		/* XXX: This is broken.  type is PurpleNotifyMsgType, not
+		 * PurpleNotifyType.  Also, the if() followed by the
+		 * inner switch doesn't make much sense.
+		 */
 		if (type == PURPLE_NOTIFY_FORMATTED) {
 			int width = -1, height = -1;
 			char *plain = (char*)secondary;


More information about the Commits mailing list