pidgin: be4048cf: msn: Avoid reading uninit memory.

darkrain42 at pidgin.im darkrain42 at pidgin.im
Wed May 11 01:12:48 EDT 2011


----------------------------------------------------------------------
Revision: be4048cf67877f0854ca049d70f8e92f0225bfe4
Parent:   5f2d11fb676ccfed13889bf069f4fef30677bdf4
Author:   darkrain42 at pidgin.im
Date:     05/11/11 01:00:06
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/be4048cf67877f0854ca049d70f8e92f0225bfe4

Changelog: 

msn: Avoid reading uninit memory.

This can't happen at any of the existing call points.

Changes against parent 5f2d11fb676ccfed13889bf069f4fef30677bdf4

  patched  libpurple/protocols/msn/directconn.c

-------------- next part --------------
============================================================
--- libpurple/protocols/msn/directconn.c	2f273f936b3288794e4634cf0471488f9a296856
+++ libpurple/protocols/msn/directconn.c	0427064d03afb76b56eb23d7eeb7c932ffe9d882
@@ -51,6 +51,9 @@ msn_dc_calculate_nonce_hash(MsnDirectCon
 		purple_cipher_context_destroy(context);
 	} else if (type == DC_NONCE_PLAIN) {
 		memcpy(digest, nonce, 16);
+	} else {
+		nonce_hash[0] = '\0';
+		g_return_if_reached();
 	}
 
 	g_sprintf(nonce_hash,


More information about the Commits mailing list