cpw.nader.asynclogging-3: c1f7933e: Fixed critical errors due to unref'ing a...

morshed.nader at gmail.com morshed.nader at gmail.com
Tue May 17 14:36:14 EDT 2011


----------------------------------------------------------------------
Revision: c1f7933ec3c3cece5a52a30f3f7d7aed2fbe149e
Parent:   c60a71e810a47a8559c2743432ff0e3b5ea69283
Author:   morshed.nader at gmail.com
Date:     05/17/11 14:22:59
Branch:   im.pidgin.cpw.nader.asynclogging-3
URL: http://d.pidgin.im/viewmtn/revision/info/c1f7933ec3c3cece5a52a30f3f7d7aed2fbe149e

Changelog: 

Fixed critical errors due to unref'ing a GFile too many times

Changes against parent c60a71e810a47a8559c2743432ff0e3b5ea69283

  patched  libpurple/htmllog.c

-------------- next part --------------
============================================================
--- libpurple/htmllog.c	0bec1877331371236495937cb9249dc54346a385
+++ libpurple/htmllog.c	1f14a0da492abe94e4839454b02c02c2628b547b
@@ -213,11 +213,8 @@ purple_html_log_write(PurpleLog *log, Pu
 
 	stream = g_file_append_to(file, G_FILE_CREATE_NONE, cancellable, error);
 
-	if (stream == NULL) {
-		g_object_unref(file);
-
+	if (stream == NULL)
 		return -1;
-	}
 
 	out_stream = G_OUTPUT_STREAM(stream);
 
@@ -258,7 +255,6 @@ purple_html_log_write(PurpleLog *log, Pu
 		g_free(line);
 
 		if (!success) {
-			g_object_unref(file);
 			g_object_unref(stream);
 
 			return -1;
@@ -340,7 +336,6 @@ purple_html_log_write(PurpleLog *log, Pu
 	g_free(date);
 	g_free(msg_fixed);
 	g_free(escaped_from);
-	g_object_unref(file);
 	g_object_unref(stream);
 
 	return size;


More information about the Commits mailing list