pidgin: 49b991d4: purple_conv_chat_set_users() has been de...

andrew.victor at mxit.com andrew.victor at mxit.com
Mon Sep 5 17:50:48 EDT 2011


----------------------------------------------------------------------
Revision: 49b991d4faffe24e4129fbf56a68babc4542f0e5
Parent:   b0ddc50414a7414193d23c8357e5e901ca4412fe
Author:   andrew.victor at mxit.com
Date:     09/05/11 16:16:47
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/49b991d4faffe24e4129fbf56a68babc4542f0e5

Changelog: 

purple_conv_chat_set_users() has been deprecated since 2.9.0, and can be removed for 3.0.0.


Changes against parent b0ddc50414a7414193d23c8357e5e901ca4412fe

  patched  ChangeLog.API
  patched  libpurple/conversation.c
  patched  libpurple/conversation.h
  patched  libpurple/plugins/perl/common/Conversation.xs

-------------- next part --------------
============================================================
--- libpurple/conversation.c	f9c02951a692d25f09e4c472417d29fded4e5273
+++ libpurple/conversation.c	0a9c5f08404bbde184536fe5c9989efbace4b59c
@@ -1379,16 +1379,6 @@ GList *
 }
 
 GList *
-purple_conv_chat_set_users(PurpleConvChat *chat, GList *users)
-{
-	g_return_val_if_fail(chat != NULL, NULL);
-
-	chat->in_room = users;
-
-	return users;
-}
-
-GList *
 purple_conv_chat_get_users(const PurpleConvChat *chat)
 {
 	g_return_val_if_fail(chat != NULL, NULL);
============================================================
--- libpurple/conversation.h	e3eda6d7875023eb7066d409e9623aee78bc9e2b
+++ libpurple/conversation.h	7458fc4790d5e03ff879de2381a11b407b3e16d3
@@ -1080,22 +1080,6 @@ PurpleConversation *purple_conv_chat_get
 PurpleConversation *purple_conv_chat_get_conversation(const PurpleConvChat *chat);
 
 /**
- * Sets the list of users in the chat room.
- *
- * @note Calling this function will not update the display of the users.
- *       Please use purple_conv_chat_add_user(), purple_conv_chat_add_users(),
- *       purple_conv_chat_remove_user(), and purple_conv_chat_remove_users() instead.
- *
- * @param chat  The chat.
- * @param users The list of users.
- *
- * @return The list passed.
- *
- * @deprecated This function will be removed in 3.0.0.  You shouldn't be using it anyway.
- */
-GList *purple_conv_chat_set_users(PurpleConvChat *chat, GList *users);
-
-/**
  * Returns a list of users in the chat room.  The members of the list
  * are PurpleConvChatBuddy objects.
  *
============================================================
--- libpurple/plugins/perl/common/Conversation.xs	93523a4b31d84d29231091710d70039703480336
+++ libpurple/plugins/perl/common/Conversation.xs	1d2c427dff5e5fad19190ca86eafa90546ecceb4
@@ -338,24 +338,6 @@ void
 	Purple::Conversation::Chat chat
 
 void
-purple_conv_chat_set_users(chat, users)
-	Purple::Conversation::Chat chat
-	SV * users
-PREINIT:
-	GList *l, *t_GL;
-	int i, t_len;
-PPCODE:
-	t_GL = NULL;
-	t_len = av_len((AV *)SvRV(users));
-
-	for (i = 0; i <= t_len; i++)
-		t_GL = g_list_append(t_GL, SvPVutf8_nolen(*av_fetch((AV *)SvRV(users), i, 0)));
-
-	for (l = purple_conv_chat_set_users(chat, t_GL); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(purple_perl_bless_object(l->data, "Purple::ListEntry")));
-	}
-
-void
 purple_conv_chat_get_users(chat)
 	Purple::Conversation::Chat chat
 PREINIT:
============================================================
--- ChangeLog.API	d78a2fd82fe3c4856c198156c15de4238bf4befb
+++ ChangeLog.API	6c7be88ba4d6f51f57d4ee94733e7ac7e0b0da2c
@@ -114,6 +114,7 @@ version 3.0.0 (??/??/????):
 		* purple_buddy_icons_set_custom_icon
 		* purple_connection_error_reason
 		* purple_contact_set_alias
+		* purple_conv_chat_set_users
 		* purple_core_migrate
 		* purple_dnsquery_a_account
 		* purple_notify_searchresults_column_get_title


More information about the Commits mailing list