/soc/2012/sanket/statscollector-2.x.y: 6f72c1ef9f29: Clean up co...
sanket
sanket at soc.pidgin.im
Wed Aug 1 16:19:21 EDT 2012
Changeset: 6f72c1ef9f29deec3664c4e0deb6d127272e823d
Author: sanket <sanket at soc.pidgin.im>
Date: 2012-08-01 13:18 +0530
Branch: soc.2012.statscollector
URL: http://hg.pidgin.im/soc/2012/sanket/statscollector-2.x.y/rev/6f72c1ef9f29
Description:
Clean up confirm dialog box
Cleaned up excess underscores (which did not seem to work in finch)
and added a delay in confirm dialog box, to make UI more responsive.
Also removed excessive warnings.
diffstat:
libpurple/plugins/statscollector.c | 41 +++----------------------------------
1 files changed, 4 insertions(+), 37 deletions(-)
diffs (66 lines):
diff --git a/libpurple/plugins/statscollector.c b/libpurple/plugins/statscollector.c
--- a/libpurple/plugins/statscollector.c
+++ b/libpurple/plugins/statscollector.c
@@ -1073,35 +1073,6 @@ show_confirm_dialog(gpointer data){
* to collect the stats
*/
- /* PurpleRequestFields *request; */
- /* PurpleRequestFieldGroup *group; */
- /* PurpleRequestField *field; */
-
- /* group = purple_request_field_group_new(NULL); */
-
- /* field = purple_request_field_label_new("confirm_dialog", \\ */
- /* "Would you like to collect statistics anonymously?"); */
- /* field = purple_request_field_account_new("acct", _("Account"), NULL); */
- /* purple_request_field_account_set_filter(field, NULL); */
- /* purple_request_field_account_set_show_all(field, FALSE); */
- /* purple_request_field_group_add_field(group, field); */
-
- /* field = purple_request_field_int_new("mins", _("Minutes"), 10); */
- /* purple_request_field_group_add_field(group, field); */
-
- /* request = purple_request_fields_new(); */
- /* purple_request_fields_add_group(request, group); */
-
- /* purple_request_fields(NULL, */
- /* "Statisitcs collection", */
- /* "Looks like this is the first time you are using the plugin!", */
- /* NULL, */
- /* request, */
- /* "Allow", confirm_allow, */
- /* "Deny", confirm_deny, */
- /* NULL, NULL, NULL, */
- /* NULL); */
-
purple_request_action(NULL,
"Statistics Collection Plugin",
"Do you wish pidgin to collect and send statistics anonymously",
@@ -1112,9 +1083,9 @@ show_confirm_dialog(gpointer data){
NULL,
NULL,
3,
- "_Allow", confirm_allow,
- "_Deny", confirm_deny,
- "_Ask Later", confirm_later);
+ _("Allow"), confirm_allow,
+ _("Deny"), confirm_deny,
+ _("Ask Later"), confirm_later);
return FALSE;
@@ -1140,12 +1111,8 @@ plugin_load(PurplePlugin *plugin) {
check_ask = purple_prefs_get_int("/plugins/core/statscollector/allow");
if(check_ask == ASK){
-
- /* purple_timeout_add_seconds(5, show_confirm_dialog, NULL); */
- show_confirm_dialog(NULL);
-
+ purple_timeout_add_seconds(5, show_confirm_dialog, NULL);
}
-
else if(check_ask == ALLOW){
/* Load the stats file into a global variable for any updations */
More information about the Commits
mailing list