/pidgin/main: 0215244831ec: Remove gtk_webview_is_empty.

Elliott Sales de Andrade qulogic at pidgin.im
Mon Aug 6 03:42:20 EDT 2012


Changeset: 0215244831ec20a0e57a8693d4f462d3a9e39d9b
Author:	 Elliott Sales de Andrade <qulogic at pidgin.im>
Date:	 2012-08-03 23:15 -0400
Branch:	 default
URL: http://hg.pidgin.im/pidgin/main/rev/0215244831ec

Description:

Remove gtk_webview_is_empty.

The emptiness of a GtkWebView is better determined by the code that
uses it.

diffstat:

 pidgin/gtkwebview.c |  15 ---------------
 pidgin/gtkwebview.h |  11 -----------
 2 files changed, 0 insertions(+), 26 deletions(-)

diffs (67 lines):

diff --git a/pidgin/gtkwebview.c b/pidgin/gtkwebview.c
--- a/pidgin/gtkwebview.c
+++ b/pidgin/gtkwebview.c
@@ -55,8 +55,6 @@ static guint signals[LAST_SIGNAL] = { 0 
  *****************************************************************************/
 
 typedef struct _GtkWebViewPriv {
-	gboolean empty;     /**< whether anything has been appended **/
-
 	/* Processing queues */
 	GQueue *html_queue;
 	GQueue *js_queue;
@@ -162,7 +160,6 @@ process_html_queue(GtkWebView *webview)
 	body = webkit_dom_document_get_body(doc);
 	webkit_dom_html_element_insert_adjacent_html(body, "beforeend", html, NULL);
 	g_free(html);
-	priv->empty = FALSE;
 
 	return TRUE;
 }
@@ -489,7 +486,6 @@ gtk_webview_init(GtkWebView *webview, gp
 {
 	GtkWebViewPriv *priv = GTK_WEBVIEW_GET_PRIVATE(webview);
 
-	priv->empty = TRUE;
 	priv->html_queue = g_queue_new();
 	priv->js_queue = g_queue_new();
 
@@ -533,17 +529,6 @@ gtk_webview_get_type(void)
  * Public API functions
  *****************************************************************************/
 
-gboolean
-gtk_webview_is_empty(GtkWebView *webview)
-{
-	GtkWebViewPriv *priv;
-
-	g_return_val_if_fail(webview != NULL, TRUE);
-
-	priv = GTK_WEBVIEW_GET_PRIVATE(webview);
-	return priv->empty;
-}
-
 char *
 gtk_webview_quote_js_string(const char *text)
 {
diff --git a/pidgin/gtkwebview.h b/pidgin/gtkwebview.h
--- a/pidgin/gtkwebview.h
+++ b/pidgin/gtkwebview.h
@@ -94,17 +94,6 @@ GType gtk_webview_get_type(void);
 GtkWidget *gtk_webview_new(void);
 
 /**
- * TODO WEBKIT: Right now this just tests whether an append has been called
- * since the last clear or since the Widget was created.  So it does not
- * test for load_string's called in between.
- *
- * @param webview The GtkWebView object
- *
- * @return gboolean indicating whether the webview is empty
- */
-gboolean gtk_webview_is_empty(GtkWebView *webview);
-
-/**
  * A very basic routine to append html, which can be considered
  * equivalent to a "document.write" using JavaScript.
  *



More information about the Commits mailing list