/pidgin/main: 928d59fabd2f: More error logging.

Mark Doliner mark at kingant.net
Sat Dec 29 02:59:42 EST 2012


Changeset: 928d59fabd2f8410804d0d20cb5f8c93bb5dfa66
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2012-12-28 23:59 -0800
Branch:	 default
URL: http://hg.pidgin.im/pidgin/main/rev/928d59fabd2f

Description:

More error logging.

There's another call to g_remove a little higher up, but we can't easily add
logging for that one because it will fail under normal circumstances, when the
top dir of the theme was g_renamed into the user's themes directory.

diffstat:

 pidgin/gtkprefs.c |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (15 lines):

diff --git a/pidgin/gtkprefs.c b/pidgin/gtkprefs.c
--- a/pidgin/gtkprefs.c
+++ b/pidgin/gtkprefs.c
@@ -948,7 +948,10 @@ theme_install_theme(char *path, struct t
 
 				prefs_themes_refresh();
 			} else {
-				g_remove(temp_path);
+				if (g_remove(temp_path)) {
+					purple_debug_error("gtkprefs", "Error removing %s: %s\n",
+							temp_path, g_strerror(errno));
+				}
 				purple_notify_error(NULL, NULL, _("Theme failed to load."), NULL);
 			}
 		} else {



More information about the Commits mailing list