/pidgin/main: f19649cf724b: Actually remove purple_conversation_...

Mark Doliner mark at kingant.net
Sun Dec 30 02:34:39 EST 2012


Changeset: f19649cf724b44454f6dd7d2dea485c1753b583d
Author:	 Mark Doliner <mark at kingant.net>
Date:	 2012-12-29 23:34 -0800
Branch:	 default
URL: http://hg.pidgin.im/pidgin/main/rev/f19649cf724b

Description:

Actually remove purple_conversation_do_command

We don't call this function ourselves.  Was it intended for plugins or
something...?  I already added an entry for this to ChangeLog.API,
so if we revert this comment we should revert that commit, too.

diffstat:

 libpurple/conversation.c |  12 ------------
 libpurple/conversation.h |  13 -------------
 2 files changed, 0 insertions(+), 25 deletions(-)

diffs (45 lines):

diff --git a/libpurple/conversation.c b/libpurple/conversation.c
--- a/libpurple/conversation.c
+++ b/libpurple/conversation.c
@@ -2501,18 +2501,6 @@ gpointer purple_conversation_get_ui_data
 	return conv->ui_data;
 }
 
-
-gboolean
-purple_conversation_do_command(PurpleConversation *conv, const gchar *cmdline,
-				const gchar *markup, gchar **error)
-{
-	char *mark = (markup && *markup) ? NULL : g_markup_escape_text(cmdline, -1), *err = NULL;
-	PurpleCmdStatus status = purple_cmd_do_command(conv, cmdline, mark ? mark : markup, error ? error : &err);
-	g_free(mark);
-	g_free(err);
-	return (status == PURPLE_CMD_STATUS_OK);
-}
-
 void *
 purple_conversations_get_handle(void)
 {
diff --git a/libpurple/conversation.h b/libpurple/conversation.h
--- a/libpurple/conversation.h
+++ b/libpurple/conversation.h
@@ -1361,19 +1361,6 @@ void purple_conv_chat_cb_destroy(PurpleC
  */
 GList * purple_conversation_get_extended_menu(PurpleConversation *conv);
 
-/**
- * Perform a command in a conversation. Similar to @see purple_cmd_do_command
- *
- * @param conv    The conversation.
- * @param cmdline The entire command including the arguments.
- * @param markup  @c NULL, or the formatted command line.
- * @param error   If the command failed errormsg is filled in with the appropriate error
- *                message, if not @c NULL. It must be freed by the caller with g_free().
- *
- * @return  @c TRUE if the command was executed successfully, @c FALSE otherwise.
- */
-gboolean purple_conversation_do_command(PurpleConversation *conv, const gchar *cmdline, const gchar *markup, gchar **error);
-
 /*@}*/
 
 /**************************************************************************/



More information about the Commits mailing list