pidgin: 4a11fb56: Fix a leak in the Plugin Information win...

qulogic at pidgin.im qulogic at pidgin.im
Thu Feb 23 04:06:16 EST 2012


----------------------------------------------------------------------
Revision: 4a11fb56507f8d30842476c8e1042117c3e74a3b
Parent:   27bf4422926dc3d0225448d5b6625bea621acf11
Author:   qulogic at pidgin.im
Date:     02/22/12 23:05:51
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/4a11fb56507f8d30842476c8e1042117c3e74a3b

Changelog: 

Fix a leak in the Plugin Information window. These variables are
set in the loop and should be freed there as well.

Changes against parent 27bf4422926dc3d0225448d5b6625bea621acf11

  patched  pidgin/gtkdialogs.c

-------------- next part --------------
============================================================
--- pidgin/gtkdialogs.c	b812e5c76a47ca99808dac6795618a55c8571852
+++ pidgin/gtkdialogs.c	cd54cdcb93a130c84b318589f7638465d5cb289c
@@ -824,14 +824,15 @@ void pidgin_dialogs_plugins_info(void)
 				pver, pwebsite, pid,
 				punloadable ? "<FONT COLOR=\"#FF0000\"><B>No</B></FONT>" : "Yes",
 				ploaded ? "Yes" : "No");
+
+		g_free(pname);
+		g_free(pauthor);
 	}
 
 	plugins_info = pidgin_build_help_dialog(title, "plugins_info", str);
 	g_signal_connect(G_OBJECT(plugins_info), "destroy",
 			G_CALLBACK(gtk_widget_destroyed), &plugins_info);
 	g_free(title);
-	g_free(pname);
-	g_free(pauthor);
 }
 
 static void


More information about the Commits mailing list