pidgin: 038a9af8: Get rid of purple_certificate_display_x5...

qulogic at pidgin.im qulogic at pidgin.im
Mon Feb 27 18:11:26 EST 2012


----------------------------------------------------------------------
Revision: 038a9af81c0f61c8fa276b653cfae773cfc5d325
Parent:   1d08fdd763eb705aeb351d2d45782256bba2868d
Author:   qulogic at pidgin.im
Date:     02/26/12 00:34:08
Branch:   im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/038a9af81c0f61c8fa276b653cfae773cfc5d325

Changelog: 

Get rid of purple_certificate_display_x509, now that there's a
request API for it.

Changes against parent 1d08fdd763eb705aeb351d2d45782256bba2868d

  patched  ChangeLog.API
  patched  libpurple/certificate.c
  patched  libpurple/certificate.h

-------------- next part --------------
============================================================
--- ChangeLog.API	5d0ac3dc93b70eba41df86c9183e0adbf557b4fe
+++ ChangeLog.API	0b87f617a493b063c15bb5e962ff0f16eaa1cdd2
@@ -164,6 +164,8 @@ version 3.0.0 (??/??/????):
 		* purple_buddy_icons_set_custom_icon
 		* purple_certificate_check_signature_chain_with_failing. Use
 		  purple_certificate_check_signature_chain, instead
+		* purple_certificate_display_x509. Use purple_request_certificate,
+		  instead
 		* purple_connection_error_reason
 		* purple_connection_new
 		* purple_connection_new_unregister
============================================================
--- libpurple/certificate.c	432a7bf500a50c4b41822ef8fa1fe2d0ea5705f0
+++ libpurple/certificate.c	c0b3b4fdd07d404268347ebc7ce314f0a3de718e
@@ -2092,25 +2092,6 @@ purple_certificate_unregister_pool(Purpl
 /* Scheme-specific functions                                                */
 /****************************************************************************/
 
-void
-purple_certificate_display_x509(PurpleCertificate *crt)
-{
-	gchar *secondary;
-
-	/* Make messages */
-	secondary = purple_certificate_get_display_string(crt);
-
-	/* Make a semi-pretty display */
-	purple_notify_info(
-		NULL,         /* TODO: Find what the handle ought to be */
-		_("Certificate Information"),
-		"",
-		secondary);
-
-	/* Cleanup */
-	g_free(secondary);
-}
-
 void purple_certificate_add_ca_search_path(const char *path)
 {
 	if (g_list_find_custom(x509_ca_paths, path, (GCompareFunc)strcmp))
============================================================
--- libpurple/certificate.h	0b5281a4695170e23041f630804d4909d70241a4
+++ libpurple/certificate.h	61cff80b41ee428e6086b9c6fdac6fe4aa2c245c
@@ -834,15 +834,6 @@ purple_certificate_unregister_pool(Purpl
 
 
 /**
- * Displays a window showing X.509 certificate information
- *
- * @param crt    Certificate under an "x509" Scheme
- * @todo Will break on CA certs, as they have no Common Name
- */
-void
-purple_certificate_display_x509(PurpleCertificate *crt);
-
-/**
  * Add a search path for certificates.
  *
  * @param path   Path to search for certificates.


More information about the Commits mailing list