/pidgin/main: 811eadbbda34: This was accidentally commited by Jo...

Kevin Stange kstange at pidgin.im
Fri Jul 6 00:29:04 EDT 2012


Changeset: 811eadbbda34d0aef6b101fd3780724025e2f20a
Author:	 Kevin Stange <kstange at pidgin.im>
Date:	 2012-07-05 23:24 -0500
Branch:	 release-2.x.y
URL: http://hg.pidgin.im/pidgin/main/rev/811eadbbda34

Description:

This was accidentally commited by John and causes the triple-click bug.

I think the reason is, at least in some versions of GTK+, indicating
that we handled the double-click means that the double-click can't be
used for firing activation.  In other versions of GTK+, it seems the
treeview looks at each GDK_BUTTON_PRESS separately, and does its own
double-click testing and will still work.

References #11942

diffstat:

 pidgin/gtkblist.c |  4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diffs (14 lines):

diff --git a/pidgin/gtkblist.c b/pidgin/gtkblist.c
--- a/pidgin/gtkblist.c
+++ b/pidgin/gtkblist.c
@@ -1970,10 +1970,6 @@
 			pidgin_retrieve_user_info(b->account->gc, b->name);
 		handled = TRUE;
 	}
-	else if ((event->button == 1) && (event->type == GDK_2BUTTON_PRESS) &&
-	((PURPLE_BLIST_NODE_IS_CONTACT(node)) || (PURPLE_BLIST_NODE_IS_BUDDY(node)))) {
-               handled = TRUE;
-	}
 
 #if (1)
 	/*



More information about the Commits mailing list