/pidgin/main: dbf343cd9e05: Fix a double-free in Yahoo profile/p...

[Mihai Serban]

Changeset: dbf343cd9e0511c89303d0b88118224051daf44e
Author:	 Mihai Serban <mihai.serban at gmail.com>
Date:	 2012-07-22 04:17 -0400
Branch:	 release-2.x.y
URL: http://hg.pidgin.im/pidgin/main/rev/dbf343cd9e05

Description:

Fix a double-free in Yahoo profile/picture code.

Fixes #15053.

Committer: Elliott Sales de Andrade <qulogic at pidgin.im>

diffstat:

 libpurple/protocols/yahoo/yahoo_picture.c |  3 ---
 libpurple/protocols/yahoo/yahoo_profile.c |  4 ----
 2 files changed, 0 insertions(+), 7 deletions(-)

diffs (27 lines):

diff --git a/libpurple/protocols/yahoo/yahoo_picture.c b/libpurple/protocols/yahoo/yahoo_picture.c
--- a/libpurple/protocols/yahoo/yahoo_picture.c
+++ b/libpurple/protocols/yahoo/yahoo_picture.c
@@ -137,9 +137,6 @@
 		if (url_data != NULL) {
 			yd = gc->proto_data;
 			yd->url_datas = g_slist_prepend(yd->url_datas, url_data);
-		} else {
-			g_free(data->who);
-			g_free(data);
 		}
 	} else if (who && send_icon_info) {
 		yahoo_send_picture_info(gc, who);
diff --git a/libpurple/protocols/yahoo/yahoo_profile.c b/libpurple/protocols/yahoo/yahoo_profile.c
--- a/libpurple/protocols/yahoo/yahoo_profile.c
+++ b/libpurple/protocols/yahoo/yahoo_profile.c
@@ -1277,10 +1277,6 @@
 	url_data = purple_util_fetch_url(url, TRUE, NULL, FALSE, yahoo_got_info, data);
 	if (url_data != NULL)
 		yd->url_datas = g_slist_prepend(yd->url_datas, url_data);
-	else {
-		g_free(data->name);
-		g_free(data);
-	}
 
 	g_free(url);
 }