/soc/2012/michael/android: 8c0389c6e14f: Added comments that / w...

Michael Zangl michael at soc.pidgin.im
Sat Jun 16 08:12:49 EDT 2012


Changeset: 8c0389c6e14f7430d06ec348dae258fc4ef4bcda
Author:	 Michael Zangl <michael at soc.pidgin.im>
Date:	 2012-06-16 10:35 +0200
Branch:	 soc.2012.android
URL: http://hg.pidgin.im/soc/2012/michael/android/rev/8c0389c6e14f

Description:

Added comments that / why android is only supporting UI ops.

diffstat:

 libpurple/dnssrv.c |  12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diffs (51 lines):

diff --git a/libpurple/dnssrv.c b/libpurple/dnssrv.c
--- a/libpurple/dnssrv.c
+++ b/libpurple/dnssrv.c
@@ -294,6 +294,8 @@
 	if (query_data->fd_in != -1)
 		close(query_data->fd_in);
 #endif
+	/* Android only uses ui ops. */
+
 	g_free(query_data->query);
 	g_free(query_data);
 }
@@ -494,9 +496,7 @@
 				if (size == -1) {
 					purple_debug_warning("dnssrv", "res_query returned an error\n");
 					/* Re-read resolv.conf and friends in case DNS servers have changed */
-					#ifndef ANDROID
 					res_init();
-					#endif
 				} else
 					purple_debug_info("dnssrv", "Found 0 entries, errno is %i\n", errno);
 
@@ -726,7 +726,7 @@
 	return NULL;
 }
 #else  /* ANDROID */
-
+/* Andoid only supports ui ops, because it's libc does not include res_*. */
 #endif
 
 PurpleSrvTxtQueryData *
@@ -863,7 +863,8 @@
 		query_data->handle = purple_timeout_add(0, res_main_thread_cb, query_data);
 
 	return query_data;
-#else
+#else /* ANDROID */
+	/* Android needs UI ops */
 	query_data->error_message = "UI ops not implemented.";
 	return query_data;
 #endif
@@ -997,7 +998,8 @@
 		query_data->handle = purple_timeout_add(0, res_main_thread_cb, query_data);
 
 	return query_data;
-#else
+#else /* ANDROID */
+	/* Andoid need sto implement UI ops */
 	query_data->error_message = "UI ops not implemented.";
 	return query_data;
 #endif



More information about the Commits mailing list