/www/pidgin: 655bc9b1b012: Fix a few html correctness issues.
Daniel Atallah
datallah at pidgin.im
Tue Sep 11 12:35:51 EDT 2012
Changeset: 655bc9b1b0129c178098bb7b684844ee79dbf92e
Author: Daniel Atallah <datallah at pidgin.im>
Date: 2012-09-11 17:35 +0100
Branch: default
URL: http://hg.pidgin.im/www/pidgin/rev/655bc9b1b012
Description:
Fix a few html correctness issues.
* ampersand escaping
* nesting block elements inside inline elements (CSS seems to work the same)
* <script> type attribute
diffstat:
htdocs/index.php | 16 ++++++++--------
inc/downloads.inc | 8 ++++----
2 files changed, 12 insertions(+), 12 deletions(-)
diffs (85 lines):
diff --git a/htdocs/index.php b/htdocs/index.php
--- a/htdocs/index.php
+++ b/htdocs/index.php
@@ -15,10 +15,10 @@
<?php include($_SERVER['DOCUMENT_ROOT'] . "/../inc/blurb.downloaddetect.inc"); ?>
-<span id="frontpage_download_common">
+<div id="frontpage_download_common">
<?php if ($download_have_direct_link) { ?>
- <span id="frontpage_download_direct">
+ <div id="frontpage_download_direct">
<div id="version">
<img src="/shared/img/logo.text-big.gif" alt="Pidgin" />
@@ -28,10 +28,10 @@
<div id="download">
<img src="/shared/img/logo.pidgin.png" alt="[Pidgin Logo]" id="logo" width="107" height="185" />
<a class="sourceforge_accelerator_link" href="<?php echo $download_link; ?>">Download Now</a>
- <script>
+ <script type="text/javascript">
(function() {
var script = document.createElement('script');
- script.src = '//sourceforge.net/accelerator/js?partner_id=62&button_size=large';
+ script.src = '//sourceforge.net/accelerator/js?partner_id=62\u0026button_size=large';
script.defer = true;
var s = document.getElementsByTagName('script')[0];
s.parentNode.insertBefore(script, s);
@@ -44,11 +44,11 @@
<a href="https://developer.pidgin.im/wiki/ChangeLog">ChangeLog</a>
</p>
- </span>
+ </div>
<?php } else { ?>
- <span id="frontpage_download_indirect">
+ <div id="frontpage_download_indirect">
<div id="version">
<img src="/shared/img/logo.text-big.gif" alt="Pidgin" />
@@ -70,10 +70,10 @@
<p class="linkbar"><a href="https://developer.pidgin.im/wiki/ChangeLog">ChangeLog</a></p>
- </span>
+ </div>
<?php } ?>
-</span>
+</div>
</div>
diff --git a/inc/downloads.inc b/inc/downloads.inc
--- a/inc/downloads.inc
+++ b/inc/downloads.inc
@@ -15,10 +15,10 @@ include($_SERVER['DOCUMENT_ROOT'] . "/..
'description' => 'Download the free Pidgin universal chat client for Windows',
'body' => '<p class="download_button">
<a class="sourceforge_accelerator_link" href="http://sourceforge.net/projects/pidgin/files/Pidgin/' . $pidgin_win32_version . '/pidgin-' . $pidgin_win32_version . '.exe/download">Download Now</a>
-<script>
+<script type="text/javascript">
(function() {
var script = document.createElement("script");
- script.src = "//sourceforge.net/accelerator/js?partner_id=62&button_size=large";
+ script.src = "//sourceforge.net/accelerator/js?partner_id=62\u0026button_size=large";
script.defer = true;
var s = document.getElementsByTagName("script")[0];
s.parentNode.insertBefore(script, s);
@@ -79,10 +79,10 @@ include($_SERVER['DOCUMENT_ROOT'] . "/..
'description' => 'Download the source code for the free Pidgin universal chat client',
'body' => '<p class="download_button">
<a class="sourceforge_accelerator_link" href="http://sourceforge.net/projects/pidgin/files/Pidgin/' . $pidgin_version . '/pidgin-' . $pidgin_version . '.tar.bz2/download">Download Now</a>
-<script>
+<script type="text/javascript">
(function() {
var script = document.createElement("script");
- script.src = "//sourceforge.net/accelerator/js?partner_id=62&button_size=large";
+ script.src = "//sourceforge.net/accelerator/js?partner_id=62\u0026button_size=large";
script.defer = true;
var s = document.getElementsByTagName("script")[0];
s.parentNode.insertBefore(script, s);
More information about the Commits
mailing list